Psychologist Loadout Improvements #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds three new alternative job title PDAs: - Psychiatrist - Therapist (req. 4hrs psych) - Social Worker (req. 4hrs service) Adds head, outer clothing, scarf, and shoe loadout groups to the psychologist. Adds a blue folder to the psychologist's starting equipment.
github-actions
bot
added
S: Needs Review
size/M
Lyndomen
reviewed
Dec 17, 2024
Lyndomen
reviewed
Dec 17, 2024
I hate YAML. This whitespace should not exist, but removing it would cause merge conflicts or something equally stupid. Signed-off-by: Michelle Szinger <[email protected]>
I hate YAML. This whitespace should not exist, but its removal would lead to merge conflicts or diff messiness or other such nonsense, so. Signed-off-by: Michelle Szinger <[email protected]>
This one is actually my bad. Apologies. Signed-off-by: Michelle Szinger <[email protected]>
|
Apologies for doing the whitespace fixup in the web UI, but it was literally IMPOSSIBLE to do in Rider for some reason (it either would not let me commit the fix or was un-fixing it before it could be committed). All the actual meaningful code changes were done in Rider, though, and were verified to be functional (at least on my machine). |
Radezolid
reviewed
Dec 17, 2024
deltanedas
requested changes
Dec 18, 2024
I hate YAML. Not even sure how this particular mistake happened, but I hate YAML. Note to self: stop using Rider for YAML changes.
deltanedas
approved these changes
Dec 18, 2024
|
Under direction review, 24 hours |
Lyndomen
approved these changes
Dec 19, 2024
So they could! I would love to hear specific suggestions over on the discord. But yea, out of scope for this. Thank you! |
|
@deltanedas this PR is now both deltanedas- and direction-approved, correct? can it become real now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds three new alternative job title PDAs:
Adds head, outer clothing, scarf, and shoe loadout groups to the psychologist.
Adds a blue folder to the psychologist's starting equipment.
Why / Balance
This change adds a bit more variety to the psychologist's starting loadout options. Since psychologist is an RP-heavy role, this allows for a bit more diversity of RP and appearances, especially with the new alternative job titles. Also, the capacity to spawn with a coat is invaluable on Glacier.
For more discussion, see the initial WYCI suggestion on the DeltaV discord.
Technical details
Adds a handful of new loadouts and new loadout groups, and makes the YAML changes necessary to have them work. Also adds three new sprites and a few new localizations for loadout group names and alternative job titles. No C# changes whatsoever.
Media
in-game screenshots
loadout menu screenshots
Requirements
Breaking changes
N/A.
Changelog
🆑