Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream merge 7/12 #2389

Merged
merged 220 commits into from
Dec 17, 2024
Merged

upstream merge 7/12 #2389

merged 220 commits into from
Dec 17, 2024

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Dec 7, 2024

Notable changes

  • succumb action has 10 second delay to avoid poison cheesing
  • there is an admin remarks button in the lobby now
  • singulo generator wont work without containment fields
  • exped fixes, i never cherry picked them early so they were still broken :trollface:
  • dim light bulbs, they can probably replace the deltav maints lights
  • derelict borg event, borg with funny laws
  • wizard access for admemes
  • station anchor beacon for mapping
  • greytide virus, the announcement is renamed

Notable exclusions

  • salv vendor grappling hook increase since grappling hooks are commented out from the vendor
  • burnt tile removal because tile migrations dont work

Changelog
🆑

  • add: Merged mid november-december changes from upstream.

RedBookcase and others added 30 commits December 7, 2024 15:42
* Add succumb action 10 sec delay

* add somthing

* add delay to last words as well

---------

Co-authored-by: slarticodefast <[email protected]>
* Adds storage sprite for gorilla gauntlet

* Specifies a heavier hitsound for gorilla gauntlet

* Modifies gauntlet icon and storage sprite

* Updates credit to my new username
* First commit

* Fixes

* Added the noise

* Renames

* Timespan

* Fixed space

* entity -> ent

* This shouldn't work

* opps....

* Datafield name change

* Better comments

* small comment

* Personal skill issue

* Event renames and stuff

* Couple fixes

* Defib ref fixes (Silly me)

* Added clumsy back!

* no hard code clumsy!

* Identity fix

* Event name change

* Comment change

* Function name change

* opp

* Update names

* Damage stuff!

* Fixes!

* Fixes

* opps

* This was hidden away!!

* negative diff feeds me
* Improve crayon UI to not be stuck in 1996

* Make a horrifying crayon spaghetti

* Crayon

* Undeprecate the crayon, describe the crayon
Added the brb sign to the Bureaucracy Crate
handle event when using seed extractor

Co-authored-by: slarticodefast <[email protected]>
* more flatpacks + glass

* solar crate price increase

* price increase

* 1250 spesos

* Update Resources/Prototypes/Catalog/Fills/Crates/engines.yml

---------

Co-authored-by: slarticodefast <[email protected]>
* Modifies label sprites and adds label visuals to closets

* Removes redundant GenericVisualizer component
* mostly done but there's a bug with spawning

* RandomGlobalSpawnSpellEvent now actually works

* Summon Guns/Magic is working

* Added sound, cap gun, and auto pick up

* Added all requested changes/fixes from reviews

* Halving cooldowns
* butcherable surgery caps

* readded cardboard box

* butcherable now?

* butcherable now?

* one day ill figure this out

* changed label of hyperzine syringe

* removed the thing in hats.yml that wasn't supposed to be here

* Update Resources/Prototypes/Entities/Objects/Specific/Medical/healing.yml

---------

Co-authored-by: slarticodefast <[email protected]>
* Organize Sandbox Panel

* Map Editing -> Editing

* Unset ToggleMode on Suicide button. Can hardly un-suicide, no?

* Remove 'Link machines' button that has done nothing for 3 years

* Remember Sandbox window's position instead of forcing to center

* Shows Spawns -> Show Spawns

* Remove SandboxSystem.MachineLinking
@github-actions github-actions bot added the Changes: Audio Changes any audio files label Dec 7, 2024
@deltanedas
Copy link
Member Author

bolts random doors open, probably bad so disabled it

@therealDLondon
Copy link
Member

Greytide virus is a /TG/ event and it fucking SUCKS but an AI can fix it easy if they're on the ball and people call out bolted doors

@Avalon-Proto
Copy link
Contributor

Oh weird. I thought it was gonna be like some thing that turns people bald and sticks a gas mask on their face lol

@Lyndomen
Copy link
Contributor

Lyndomen commented Dec 7, 2024

Direction reviewing, will have feedback in a day on greytide. Im also dubious on this

singulo generator wont work without containment fields

so im getting some feedback. thoughts?

@MilonPL
Copy link
Member

MilonPL commented Dec 8, 2024

so im getting some feedback. thoughts?

supposed to make singuloosing as an antag roundstart harder, you can emag it to bypass it

@Radezolid
Copy link
Contributor

Wasn't it to prevent non antags from singuloosing shift start?

@MilonPL
Copy link
Member

MilonPL commented Dec 8, 2024

yes that's what i meant i woke up 10 minutes ago (since antags can just emag it)

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@deltanedas deltanedas requested a review from a team as a code owner December 13, 2024 21:05
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Dec 13, 2024
Lyndomen
Lyndomen previously approved these changes Dec 13, 2024
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singulo generator wont work without containment field
We are split down the middle on this one, we don't mind it but also don't really care

Greytide virus is fine, but please relabel to something like
"Rogue subroutine detected in door servos. Check all door bolts for malfunction"

@deltanedas deltanedas merged commit 9c408f6 into DeltaV-Station:master Dec 17, 2024
12 checks passed
@deltanedas
Copy link
Member Author

bruh i squashed again

deltanedas added a commit that referenced this pull request Dec 17, 2024
@deltanedas deltanedas deleted the upstream-ops branch December 17, 2024 04:53
Comment on lines +15 to +19
<GridContainer
Rows="2"
HSeparationOverride="5"
VSeparationOverride="5"
HorizontalExpand="True">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the bulging buttons taking up the chat window intentional?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats how it used to be just less wide, can be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Map Changes: Sprite Changes any png or json in an rsi Changes: UI Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.