Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes intercoms rotate to indicate direction they are facing #2367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IamVelcroboy
Copy link
Member

@IamVelcroboy IamVelcroboy commented Dec 5, 2024

About the PR

Adjusts the intercom sprites so they rotate

Why / Balance

Like APCs and other wallmounted electronics it makes it clearer to the player which side of the wall they are on and what direction the are facing.

Technical details

n/a

Media

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an in-game showcase.

Breaking changes

n/a

Changelog
🆑 JustAnOrange

  • tweak: intercoms rotate according to direction they are facing now.

@IamVelcroboy IamVelcroboy requested a review from a team as a code owner December 5, 2024 02:07
@github-actions github-actions bot added S: Needs Review size/S 16-63 lines Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi and removed size/S 16-63 lines labels Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

RSI Diff Bot; head commit 334a8a4 merging into f49142c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Structures/Wallmounts/intercom.rsi

State Old New Status
base Added
broadcasting Added
build Added
panel Added
speaker Added
unshaded Added

Edit: diff updated after 334a8a4

Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does removing noRot not work

@IamVelcroboy
Copy link
Member Author

IamVelcroboy commented Dec 7, 2024

does removing noRot not work

nope. That's just for rotating screen I thought. Either way, just tested and no, it didn't work

Edit: I suppose we could remove the 4 directions and make it a single 32x32 texture. I think it would rotate then, but still we're replacing the texture either way

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@deltanedas deltanedas requested a review from a team as a code owner December 17, 2024 04:52
Lyndomen
Lyndomen previously approved these changes Dec 17, 2024
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% needed

@github-actions github-actions bot added size/S 16-63 lines and removed S: Merge Conflict Fix your PR! labels Dec 19, 2024
@IamVelcroboy
Copy link
Member Author

conflict resolved

"name": "panel",
"directions": 4
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untroll indent on this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any indents on my end...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixing tabs and spaces

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where though?
image
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your ide cant render it so ill fix tomorrow ig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants