Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a light to the paramedic's helmet + removal of paramedic suit storage from upstream files. #2343

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

Radezolid
Copy link
Contributor

@Radezolid Radezolid commented Dec 2, 2024

About the PR

I moved the suit storage unit from upstream's file to ours while updating it to use entity tables and added a light to the paramedic's helmet

Why / Balance

A Paramedic suit meant to be used in search and rescue would need a light to aid in it's duties.

Technical details

Adding YAML and sprites.
Moved the paramedic's suit storage + made it use EntityTableContainerFill

Media

image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Nothing... yet.

Changelog

🆑

  • tweak: Paramedics void helmets now come with a flashlight attached for better search and rescue.

@Radezolid Radezolid requested review from IamVelcroboy and a team as code owners December 2, 2024 15:57
@Radezolid Radezolid marked this pull request as draft December 2, 2024 15:57
@github-actions github-actions bot added S: Needs Review size/M 64-255 lines Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi and removed size/M 64-255 lines labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

RSI Diff Bot; head commit c6d8cd6 merging into 4cc0fca
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Head/Helmets/paramedhelm.rsi

State Old New Status
icon-flash Added
icon Added
inhand-left Added
inhand-right Added
off-equipped-HELMET-vox Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vox Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Edit: diff updated after c6d8cd6

@Radezolid
Copy link
Contributor Author

I need a hand with this one.
Sprite doesn't renderize when the light is off, but it does when it's on.
image
image

As far as I know i'm missing something and the "issue" comes from these lines:

  - type: Appearance
  - type: HandheldLight
    addPrefix: true

@Emily9031
Copy link
Contributor

Emily9031 commented Dec 2, 2024

Honestly I have no idea why this works, but I renamed some of the sprites and it seems to have fixed the bald issue.

@github-actions github-actions bot added the size/M 64-255 lines label Dec 3, 2024
@Radezolid Radezolid changed the title Add a light to the paramedic's helmet. Add a light to the paramedic's helmet + removal of paramedic suit storage from upstream files. Dec 3, 2024
@Radezolid Radezolid marked this pull request as ready for review December 3, 2024 17:34
@Radezolid
Copy link
Contributor Author

Sprites are shit, but we can change that later. I am not a good spriter.

@deltanedas deltanedas requested a review from a team as a code owner December 17, 2024 04:52
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, direction approved

@deltanedas deltanedas merged commit 8b3bd37 into DeltaV-Station:master Dec 19, 2024
20 checks passed
@Radezolid Radezolid deleted the paramed-suit-light branch December 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants