-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit footprints to 2 per tile #2270
Conversation
Is it worth removing the timed expiration of these prints? |
As a regular Janitor player I really really don't like the current state of footprints. I think its a really cool idea to have messes spread about the place, but I don't like how they disappear by themselves and remove liquid from puddles making it so if people are walking on messes the puddle evaporates without being cleaned up!! its quite annoying to play as janitor with this. it doesn't help that you have to click on each footprint individually to clean them up combined with the fact they disappear automatically means i never clean them up! I just ignore them which as someone trying to keep this place tidy is really frustrating. |
So from what I hear, we could either: |
|
||
/// <summary> | ||
/// DeltaV: Dictionary tracking footprints per tile using tile coordinates as key | ||
/// </summary> | ||
private readonly Dictionary<Vector2i, Queue<EntityUid>> _footprintsPerTile = new(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't store this in a component it gets nuked on any downstreams trying persistence.
Also obviously not storing the grid itself so breaks on multi-grid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fuck you're right, i forget that persistence is even a thing
About the PR
title
adds logic to the FootPrintsSystem.cs to track the number of footprints and limit it to 2 per tile
doesn't seem like a lot but still looks good and 1 per tile looks shit
Why / Balance
5 tps ops
Breaking changes
Changelog
🆑