Ports Bloodstains And Footprints from EE #2186
Conversation
github-actions
bot
added
S: Needs Review
Changes: YML
|
RSI Diff Bot; head commit 99293ba merging into dad219a Resources/Textures/_EE/Effects/footprints.rsi
|
Signed-off-by: Lyndomen <[email protected]>
Signed-off-by: Lyndomen <[email protected]>
Signed-off-by: Lyndomen <[email protected]>
Signed-off-by: Lyndomen <[email protected]>
|
Yay yay yay let's DO it!!! :D |
|
This might sound like a small issue, but the folders should be |
|
yes it is same code, I will import Goob-Station/Goob-Station#847 tmrw |
|
|
Not that this whole PR isn't cool and I understand the performance concerns but doesn't this sort of defeat the purpose of footprints being a source of forensics evidence and creating work for janitors? |
Yeah, it kinda does, but its maybe better than nothing? idk, Im down to change the timer if we wanna set it to 5 mins or something. All depends on the performance. |
|
I feel like they should persist a lot longer than 60 seconds, for the same reasons already given |
|
the main issue that led to it needing despawning is that you can have a stupid amount of them in a small area and cleaning didnt work, if they were limited and cleanable it would be fine |
|
we can revert it if the performance dies :blunt: |
|
it WILL die, on goob the janitors couldnt clean them no matter what and it ruined the tps |
cleaning works fwiw now |
It was client side TPS |
the visualizer should just be modified to only show the 10 top most footprints or whatever per tile
|
5 tps incident incoming |
|
i cant wait |
|
It seems this was expected, but last night during a round there was a ton of blood on the evac shuttle, and the new footsteps caused a ton of performance issues from everything being in such a small space. I confirmed with other players that it seemed to be affecting everyone, even people with very good hardware such as myself. Maybe detectives can be given a device similar to the t-ray scanner that shows footprints nearby that were cleaned or dried up. TLDR more optimization needs to be done. |
|
who could've seen this coming |
This reverts commit fdb2675.
About the PR
Puddles now get everywhere, and footprints can be cleaned up. Ported from Simple-Station/Einstein-Engines#1190
Why / Balance
Its neat, I want it, and it will make the station more immersive. Also uh, something about janitors weeping.
Technical details
Lotta C#, ported from EE. I moved stuff to EE namespace, good luck us.
Media
Requirements
Breaking changes
I mangled the C# a bit to put it in a EE namespace.
Changelog
🆑