Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new station: Byoin #1965

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Conversation

FieldCommand
Copy link

@FieldCommand FieldCommand commented Oct 5, 2024

About the PR

Adds a small station that is about twice the size of Chibi. The station is made to be relatively easy to operate with a crew soft cap of 4. This map aims to fill a very niche spot in the map rotation when there are the fewest players on the server.

Why / Balance

I made this map to add more variety when there are next to no players on the server. Making this map easy to operate with very few players. It is heavily inspired by the station "Chibi". Like the Chibi map, this map has a large reduction in many roles, including the omission of many roles that are quite RP havy.

The soft cap of this map is 4 players, but there are 24 total job slots, not including passenger
This station also has its own evacuation shuttle.

(I made a small mistake when I wrote this part of this PR, but I have tested all the content and changes and added the necessary media to showcase the PR)

Media

Byoin-1 72
Evac Basu

Changelog

  • add: Byoin station, with soft population cap of 4.
  • add: NTES Evac Basu shuttle

@FieldCommand FieldCommand requested a review from a team as a code owner October 5, 2024 02:37
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Map Changes: C# Changes any cs files and removed S: Needs Review labels Oct 5, 2024
@IamVelcroboy
Copy link
Member

@deltanedas I can't figure out what's tripping the test error. It says No user map found: /Maps/byoin.yml but byoin.yml is clearly in /Maps 🤷‍♂️

@MilonPL
Copy link
Member

MilonPL commented Oct 5, 2024

@deltanedas I can't figure out what's tripping the test error. It says No user map found: /Maps/byoin.yml but byoin.yml is clearly in /Maps 🤷‍♂️

I'm pretty sure it fails when loading the map, not because it can't find the map, as that's standard output. It's tripping because of Entity 0 which is uh, yeah. I've seen this error quite a few times in production too.

@deltanedas
Copy link
Member

remove all invalid references

@IamVelcroboy
Copy link
Member

remove all invalid references

There aren't any

@github-actions github-actions bot added the size/XL Over 1024 lines label Dec 4, 2024
@Monotheonist
Copy link
Contributor

Will Byoin have AI?

@FieldCommand
Copy link
Author

Will Byoin have AI?

Sorry for the late reply, Monotheonist.

Originally I planned to make space for one, but this was before the AI was introduced, and as the progress of making this map went along, and what role this station is trying to fill, alongside what this station is based on, I soon went away with the idea of having a station AI. But if it's needed, I will add one, but if that is to happen, I will convert this PR to draft and do some more major rework across the board to take it from graveyard hours station to be more in line with a low- to mid-pop station.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Map Changes: YML Changes any yml files size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants