medsechud take 3 #1888
Closed
medsechud take 3 #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: YML
# Conflicts: # Resources/Prototypes/DeltaV/Entities/Clothing/Eyes/glasses.yml
deltanedas
requested changes
Nov 23, 2024
| EntityManager.AddComponents(ent, ent.Comp.RemoveComponents); | ||
| } | ||
|
|
||
| Dirty(ent); |
| public bool MedicalMode = true; | ||
|
|
||
| [DataField] | ||
| public EntProtoId<InstantActionComponent> ActionId = "ActionToggleMedSecHud"; |
| - type: GuideHelp | ||
| guides: | ||
| - Security | ||
| - Antagonists | ||
| - Medical | ||
| - type: IdentityBlocker | ||
| coverage: EYES | ||
| - type: MedSecHud # we have ComponentToggler at home |
There was a problem hiding this comment.
why does this not just use ComponentToggler
There was a problem hiding this comment.
because we need to both add some and remove some components on activation
componentToggler would just add them on activation and then remove the same set of components when it's deactivated
There was a problem hiding this comment.
add the inverse to it and make upstream pr too
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
gives the corpsman glasses an action to switch between modes
you could already do that by just switching between the corpsman and security glasses, so this just gives it an action, overall qol increase
Why / Balance
permanent flash protection and maintains functionality but it has a 10s cooldown so you can't spam it
might lock it behind research in a separate PR and default to secmedhud
Technical details
new component, new system, adds an action that basically just switches between comps
requires space-wizards/space-station-14#32354 and space-wizards/space-station-14#32355
Requirements
Breaking changes
Changelog
🆑