Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thief Breaching Charges Balance #1868

Merged

Conversation

Unkn0wnGh0st333
Copy link
Contributor

@Unkn0wnGh0st333 Unkn0wnGh0st333 commented Sep 19, 2024

About the PR

Replaces C4 with Breaching Charges

Why / Balance

I believe this was a needed change due to the lethality that C4 can cause. This was made in attempt to prevent Thief murder due to C4 being a pacifist implant bypass. The Breaching Charge is a structural targeting explosive that has near to none player damage unless on the same tile, even then not even crit'ing a completely unarmored person.

Due to Breaching Charges being weaker though, a third charge was added to the kit to compensate. Though is it better suited for the kits whole point of existing, to breach into areas and steal items.

I'd love to talk more in detail about this if you guys have differing opinions

Edit: In testing breaching charge does about 90 damage to unarmored crew on top of it, while the C4 does staggeringly much more with insta crit and bleed

Technical details

Replaces C4 with Breaching Charges, Changes description of Breacher Kit on toolbox

Media

image
image
Edit: Fixed the description saying 2 to 3^

Requirements

Breaking changes

Nothing that really effects anything code wise

Changelog
🆑

  • Thief's Breacher Kit's C4 replaced with Breaching Charges

@Unkn0wnGh0st333 Unkn0wnGh0st333 requested a review from a team as a code owner September 19, 2024 22:10
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Localization Changes any ftl files labels Sep 19, 2024
@Unkn0wnGh0st333
Copy link
Contributor Author

Unkn0wnGh0st333 commented Sep 19, 2024

WOOPS MINOR WORDING MISTAKE AAAAA

@deltanedas
Copy link
Member

bad grammar in the ftl + should try this upstream first + ftl has no deltav comment above it

@MilonPL
Copy link
Member

MilonPL commented Sep 20, 2024

bad grammar in the ftl + should try this upstream first + ftl has no deltav comment above it

wdym upstream
breaching charges are a deltav thing

@Unkn0wnGh0st333
Copy link
Contributor Author

Unkn0wnGh0st333 commented Sep 20, 2024

@deltanedas Breaching charges are delta only and uhh shut up! ooo gottem

Edit: I'll fix the grammer but uhh I'm not sure how I would leave a comment on an FTL file?

@deltanedas
Copy link
Member

you have to put the comment above it, on the same line wont be commented it stays :trollface:

@Unkn0wnGh0st333
Copy link
Contributor Author

hopefully I understood what you meant by that and this doesn't fail horrifically

@TadJohnson00 TadJohnson00 merged commit c61c06a into DeltaV-Station:master Sep 21, 2024
12 checks passed
@Unkn0wnGh0st333 Unkn0wnGh0st333 deleted the Thief-Breaching-Charges branch September 22, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants