Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moth RGB 2: The electric boogaloo #184

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

DebugOk
Copy link
Contributor

@DebugOk DebugOk commented Oct 16, 2023

About the PR

Funny RGB sliders but not bad

Why / Balance

RGB moths look like shit, this blends the selected color with the default moth skintone.

Media

Content Client_YEUTFOEym8
0, 0, 0
Content Client_1F7KpVkoRd
255, 255, 255
Content Client_1iVOipGOyi
255, 0, 0
Content Client_agok9doa6t
0, 255, 0
Content Client_oiQvjszbLD
0, 0, 255

Changelog
🆑

  • tweak: Moth coloration has been changed, existing characters might look slightly weird

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in game, nice!

Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much how skin tones work, but it looks fine.

@DebugOk
Copy link
Contributor Author

DebugOk commented Oct 16, 2023

I don't know much how skin tones work, but it looks fine.

It's all mystery math that somehow ends up working lol

@DebugOk DebugOk merged commit 665c3df into DeltaV-Station:master Oct 17, 2023
12 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Oct 17, 2023
@ghost ghost mentioned this pull request Aug 28, 2024
2 tasks
TadJohnson00 pushed a commit that referenced this pull request Sep 8, 2024
Undo everything PR #184 does with this one simple trick

Co-authored-by: deltanedas <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
## Mirror of PR #25992: [foxes are now neutral🦊
](space-wizards/space-station-14#25992) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `86ab7a10743bd98d1f187e7158cb316e106ea3b9`

PR opened by <img
src="https://avatars.githubusercontent.com/u/93311212?v=4"
width="16"/><a href="https://github.com/icekot8"> icekot8</a> at
2024-03-11 10:27:27 UTC

---

PR changed 1 files with 16 additions and 1 deletions.

The PR had the following labels:
- No C#


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> This PR adds 8 piercing damage to foxes and makes them neutral rather
than peaceful.
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> this seems logical. At this point, the fox is not neutral, although it
is originally a predatory animal.
> 
> I think 8 piercing for their bite is fair damage considering their
origin.
> `attackMemoryLength` = 10, because that's the average value for this
metric.
> 
> I don't think we should discount animals from their relatives, Renault
will have exactly the same behavior. We have Shiva, after all.
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑
> - tweak: Foxes are now neutral and deal 8 piercing damage


</details>

Co-authored-by: SimpleStation14 <Unknown>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants