Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dreammyrr patch 3 #1813

Closed
wants to merge 21 commits into from
Closed

Dreammyrr patch 3 #1813

wants to merge 21 commits into from

Conversation

Dreammyrr
Copy link

About the PR

Why / Balance

Technical details

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Eagle-0 and others added 21 commits September 5, 2024 19:23
@Eagle-0 @Tropica1Owl
Merge pull request DeltaV-Station#11 from Tropica1Owl/Pogmed
79e504d 
Surgery situation is crazy
@Eagle-0 @Tropica1Owl
Merge pull request DeltaV-Station#12 from Tropica1Owl/Pogmed
682722e 
Surgery situation got even worse
@Eagle-0 @Tropica1Owl
Merge pull request DeltaV-Station#15 from Tropica1Owl/Pogmed
c5e01da 
Transplant surgery
@Eagle-0 @Tropica1Owl
Merge pull request DeltaV-Station#16 from Tropica1Owl/Pogmed
35395ac 
Surgery condition rework + guidebook entry
@Eagle-0 @Tropica1Owl
Merge pull request DeltaV-Station#17 from Tropica1Owl/Pogmed
1c1745f 
Medical biofabricator + surgery extras
@Tropica1Owl
cirurgia
50d8755
@Dreammyrr
Cirurgia (#1)
a59275a 
<!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- The text between the arrows are comments - they will not be visible
on your PR. -->

## About the PR
<!-- What did you change in this PR? -->
Esse PR porta o sistema de cirurgia que eu estava programando para o
server gringo Syndicate Station, algumas coisas foram alteradas para
funcionar melhor no Delta-V.

Um guia em inglês explicando os básicos está disponível dentro do
guidebook, anexado ao guia do trabalho de médico.

## Why / Balance
<!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
Cirurgia é legal e pá

## Technical details
<!-- If this is a code change, summarize at high level how your new code
works. This makes it easier to review. -->
Não dá pra remover órgãos, apenas botar, e quando os órgãos são
colocados eles excluem os antigos

## Media
<!-- 
PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
Small fixes/refactors are exempt.
Any media may be used in SS14 progress reports, with clear credit given.

If you're unsure whether your PR will require media, ask a maintainer.
-->

## Requirements
<!-- 
Due to influx of PR's we require to ensure that PR's are following the
correct guidelines.

Please take a moment to read these if its your first time.

Check the boxes below to confirm that you have in fact seen these (put
an X in the brackets, like [X]):
-->
- [x] I have read and I am following the [Pull Request
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
I understand that not doing so may get my pr closed at maintainer’s
discretion
- [x] I have added screenshots/videos to this PR showcasing its changes
ingame, **or** this PR does not require an ingame showcase

## Breaking changes
<!--
List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
-->

**Changelog**
<!--
Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
-->

<!--
Make sure to take this Changelog template out of the comment block in
order for it to show up. Changelog must have a 🆑 symbol, so the bot
recognizes the changes and adds them to the game's changelog.
🆑
- add: Added fun!
- remove: Removed fun!
- tweak: Changed fun!
- fix: Fixed fun!
-->
@Dreammyrr
Update security.yml
5fa5cae 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update DefaultRules.xml
60337b6 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update RoleTypes.xml
e19ad46 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update CriminalRecords.xml
06edf32 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update Defusal.xml
c1c3905 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update Forensics.xml
b753d05 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update Security.xml
707854d 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Musicas para a Jukebox
09a28d8 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update attributions.yml
793fdbb 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update Standard.yml
db0c680 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Update runserver.bat
75c9019 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr
Tradução (#2)
faf1a81 
<!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- The text between the arrows are comments - they will not be visible
on your PR. -->

## About the PR
<!-- What did you change in this PR? -->

## Why / Balance
<!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->

## Technical details
<!-- If this is a code change, summarize at high level how your new code
works. This makes it easier to review. -->

## Media
<!-- 
PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
Small fixes/refactors are exempt.
Any media may be used in SS14 progress reports, with clear credit given.

If you're unsure whether your PR will require media, ask a maintainer.
-->

## Requirements
<!-- 
Due to influx of PR's we require to ensure that PR's are following the
correct guidelines.

Please take a moment to read these if its your first time.

Check the boxes below to confirm that you have in fact seen these (put
an X in the brackets, like [X]):
-->
- [ ] I have read and I am following the [Pull Request
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
I understand that not doing so may get my pr closed at maintainer’s
discretion
- [ ] I have added screenshots/videos to this PR showcasing its changes
ingame, **or** this PR does not require an ingame showcase

## Breaking changes
<!--
List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
-->

**Changelog**
<!--
Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
-->

<!--
Make sure to take this Changelog template out of the comment block in
order for it to show up. Changelog must have a 🆑 symbol, so the bot
recognizes the changes and adds them to the game's changelog.
🆑
- add: Added fun!
- remove: Removed fun!
- tweak: Changed fun!
- fix: Fixed fun!
-->
@Dreammyrr
Merge branch 'DeltaV-Station:master' into master
fcb0c2d
@Dreammyrr
Guidebook da Sec atualizado, adição da spacelaw
295e098 
Signed-off-by: Dreammyrr <[email protected]>
@Dreammyrr Dreammyrr requested review from IamVelcroboy and a team as code owners September 11, 2024 22:52
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an rsi labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

RSI Diff Bot; head commit 295e098 merging into 0b20628
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Palmtree/Objects/Specific/Medical/surgery.rsi

State Old New Status
antirot Added
bloodfilter Added

Resources/Textures/Palmtree/Structures/Machines/limbgrower.rsi

State Old New Status
limbgrower_fill Added
limbgrower_idleoff Added
limbgrower_idleon Added
limbgrower_openpanel Added
limbgrower_panelopen Added
limbgrower_unfill Added

@therealDLondon
Copy link
Member

I dont mean this to come across as rude, but what is all this?

@Colin-Tel
Copy link
Contributor

idk why you opened like 5 PRs for this, but please keep it to one.

Also what the heck is this

@deltanedas
Copy link
Member

please stop

@deltanedas deltanedas closed this Sep 12, 2024
@Tropica1Owl
Copy link

I'm sorry for everyone involved

I dont mean this to come across as rude, but what is all this?

Brazilian songs, portuguese translation, and surgery
I had no hand in this other than the surgery, and it's really funny that he just tried pr'ing his whole fork from top to bottom.

@Dreammyrr Dreammyrr deleted the Dreammyrr-patch-3 branch September 23, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamVelcroboy IamVelcroboy Awaiting requested review from IamVelcroboy

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dreammyrr @therealDLondon @Colin-Tel @deltanedas @Tropica1Owl @Eagle-0