Armour Rework (lyndo please cook) #1687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into armourrework
|
This is intended to go live with one or two other PRs, shock damage + blunt damage stamina rebuild + weapon rebalance stun meta btfo |
ghost
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Seems good, but you should rewrite some of the comments so the change is documented from like, 0.75 to 0.85 just as a reference of how it was before. Having everything just say "General armor rebalance" gives no future yaml people who want to change this any clue how it was and kinda forces them to look up the PR.
|
Added comments as requested |
|
Keep cooking 👍 |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adjusted armour values (touches delta, wiz, and nyano files) in anticipation of #1672
Why / Balance
See above
Technical details
n/a
Media
n/a
Requirements
Breaking changes
n/a
Changelog
🆑 TJohnson & Lyndomen