Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add atmos stuff for mapping vox boxes #1668

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

deltanedas
Copy link
Member

About the PR

  • add atmos fix vox box marker for 101kpa nitrogen
  • add [Vox Atmosphere] suffixed scrubber, vent, air alarm
  • gas filters can save their filtered gas so you can have it filter nitrogen roundstart

Why / Balance

mapping and john cope

Technical details

no deltav comments on the components since in maybe a year someone will change them upstream to be the same as current standards if john cope allows it

Media

scrubber filters nitrogen out
04:30:23

air alarm vox thresholds are real
04:31:34
(now widenet and manual)
04:31:21

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
no cl no fun

@deltanedas deltanedas changed the title add atmos stuff for mapping add atmos stuff for mapping vox boxes Aug 22, 2024
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files labels Aug 22, 2024
Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, guess upstream isn't getting it anytime soon!!

@deltanedas deltanedas merged commit 6dc5ff7 into DeltaV-Station:master Aug 22, 2024
12 checks passed
MilonPL added a commit to MilonPL/Delta-v that referenced this pull request Aug 23, 2024
MilonPL added a commit to MilonPL/Delta-v that referenced this pull request Aug 23, 2024
deltanedas pushed a commit to deltanedas/Delta-v that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants