Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix aac tables not working on radio #1660

Merged
merged 3 commits into from
Aug 21, 2024
Merged

fix aac tables not working on radio #1660

merged 3 commits into from
Aug 21, 2024

Conversation

MilonPL
Copy link
Member

@MilonPL MilonPL commented Aug 20, 2024

About the PR

Fixes #1610.

Why / Balance

Yet another bug fix.

Technical details

Changes RadioSystem to support the AAC tablets, speaker name gets stored in the component.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: AAC tablets now properly get picked up by intercoms.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Aug 20, 2024
deltanedas
deltanedas requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make it use VoiceMask like handheld radio does

@github-actions github-actions bot added the Changes: YML Changes any yml files label Aug 21, 2024
@MilonPL MilonPL requested a review from deltanedas August 21, 2024 05:31
@deltanedas deltanedas merged commit 2af5955 into DeltaV-Station:master Aug 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intercoms do not pick up AAC tablet's speaker
2 participants
@MilonPL @deltanedas