Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give prisoners a criminal record roundstart #1593

Closed
wants to merge 7 commits into from

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Aug 10, 2024

About the PR

title, and set them to detained automatically because they are

right now its rng but i want to change it to have a thing in profile for custom record lines

Why / Balance

why are you in perma? erm i forgot

ideally players could add their own custom records but wyci

Technical details

moved fugitive crimes data into RandomCrimes so it can be reused

Media

02:29:46

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • add: The Prisoner role now gets a random criminal record for every shift.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files labels Aug 10, 2024
@IamVelcroboy
Copy link
Member

ideally players could add their own custom records but wyci

Yeah, maybe in the future there could be a checkbox of potential crimes they could add/remove to their pool of potential crimes in chargen screen.

Love this idea overall though!

@BlitzTheSquishy
Copy link
Contributor

The system from CD would be better imo

@pissdemon
Copy link
Contributor

pissdemon commented Aug 21, 2024

I do not think this is a good change. People should be free to choose what they are in prison for. This forces your character into having a criminal record that you might not agree with as a player which can put off people from playing the role.

Those who remain are faced with the problem that they are not shown what they are in for. They cannot roleplay it until they are told, which ultimately means this does not really solve the issue of "why are you in perma? erm i forgot".

@TadJohnson00
Copy link
Contributor

Mixed on this change. I do like having them set to "detained", but there needs to be some direction discussion about whether this is a change we want for roundstart permabrig prisoners.

@deltanedas
Copy link
Member Author

yeah ill be redoing this at some point to be something you can pick in the character profile

@Samsterious
Copy link
Contributor

I would suggest taking a look at CD's employment/medical/security records. It is an unintrusive HRP mechanic that can be fairly easily ported to Delta-V without interfering with its MRP needs, and which gives players the ability to define their own IC crimes. Deciding FOR the players what their crimes are — especially because they cannot even see what their crimes are — is not a good plan. Very often the players have an idea already in mind, and we should respect that.

@deltanedas
Copy link
Member Author

yes i know already

@deltanedas deltanedas marked this pull request as draft September 11, 2024 12:36
deltanedas and others added 3 commits September 11, 2024 14:39
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Sep 12, 2024
@TadJohnson00
Copy link
Contributor

Is this still getting worked on @deltanedas or will you implement this in another PR

@deltanedas
Copy link
Member Author

db stuff is fucked i doubt it

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@deltanedas deltanedas closed this Nov 15, 2024
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 20, 2025
fixes the "missing layer" error

Co-authored-by: slarticodefast <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Merge Conflict Fix your PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants