Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix railing directional construction #1492

Closed

Conversation

portfiend
Copy link
Contributor

About the PR

railings are forced to face "south" for some ungodly reason when you build them so i fixed it

Why / Balance

stupid bug

Technical details

i just removed "southRotation"

Media

railings.mp4
  • [X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

none

Changelog

🆑 portfiend

  • fix: railings can now be built directionally

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jul 14, 2024
@portfiend portfiend marked this pull request as ready for review July 14, 2024 11:50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being PR-ed to Delta instead of Wizden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt know this was a bug on wizden too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt know this was a bug on wizden too

It might be 🤷 ; was just wondering since it's a Wizden file and assumedly it's the same on Wizden

@@ -7,31 +7,27 @@
- to: railing
completed:
- !type:SnapToGrid
southRotation: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every removed line needs to be:

#southRotation: true # Delta-V : Removes forced South Rotation for building railings

@WarMechanic
Copy link
Contributor

space-wizards/space-station-14#29687

just cherry-pick this

@DangerRevolution
Copy link
Contributor

space-wizards/space-station-14#29687

just cherry-pick this

Don't cherrypick it; just wait for it to be merged here. But yeah, looks like it was fixed on Wiz.

@WarMechanic
Copy link
Contributor

space-wizards/space-station-14#29687
just cherry-pick this

Don't cherrypick it; just wait for it to be merged here. But yeah, looks like it was fixed on Wiz.

to be honest the railing bug feels awful

@DangerRevolution
Copy link
Contributor

space-wizards/space-station-14#29687
just cherry-pick this

Don't cherrypick it; just wait for it to be merged here. But yeah, looks like it was fixed on Wiz.

to be honest the railing bug feels awful

until it causes a horrific CTD or makes rounds unplayable it's best to wait for Null

@portfiend portfiend closed this Aug 6, 2024
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
…eltaV-Station#1492)

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Adds incompatibility to ensure that someone cannot take negative visual
traits while having cyber-eyes systems, and likewise cannot take
redundant negative visual traits.

Should resolve [this
issue](Simple-Station/Einstein-Engines#1327).

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>


![githubphotophobiaimage](https://github.com/user-attachments/assets/fd27ac82-d4b5-4c67-a4ad-35c6be9862b4)


</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: You cannot take Photophobia while blind or you have cyber-eyes.
- fix: You cannot take nearsightedness while blind or while having
cyber-eyes.
- fix: You cannot be blind while nearsighted, photophobic, or while
having cyber-eyes.
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants