Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Lobby Screen, breaking space. #1448

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

Dabigoose
Copy link
Contributor

@Dabigoose Dabigoose commented Jul 1, 2024

About the PR

I added a new Lobby Screen based off the Breaking Bad poster with a background inspired by Breaking Bad, now following the Delta-v Lobby Screen template.
breakingspace

Changelog
🆑 p.r.ospector
add: Added a new lobby screen based off a show!

Signed-off-by: Dabigoose <[email protected]>
Signed-off-by: Dabigoose <[email protected]>
@github-actions github-actions bot added the Changes: YML Changes any yml files label Jul 1, 2024
Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires an attribution in Resources/Textures/LobbyScreens/attributions.yml

Also your changelog is messed up, you need to have the :cl: emoji above "add:" with (or without) your username if you want it to show up.

@Dabigoose
Copy link
Contributor Author

Requires an attribution in Resources/Textures/LobbyScreens/attributions.yml

Also your changelog is messed up, you need to have the :cl: emoji above "add:" with (or without) your username if you want it to show up.

I have made the new changes, are they better now?

@Colin-Tel Colin-Tel self-requested a review July 2, 2024 12:10
@Colin-Tel Colin-Tel merged commit 2ab45b8 into DeltaV-Station:master Jul 2, 2024
12 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Makes non-verbal languages no longer emit speech sounds. Ported from
[Goob-Station-MRP#29](Goob-Station/Goob-Station-MRP#29)
at @angelofallars's request.

---


<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>


![PR
Example](https://github.com/user-attachments/assets/8be6b705-eff7-4e2e-ab53-5648dccfc7eb)


</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- tweak: Languages that don't require speech (I.E. Sign Language) will
no longer play speech sounds.

---------

Signed-off-by: RadsammyT <[email protected]>
Co-authored-by: Skubman <[email protected]>
Co-authored-by: flyingkarii <[email protected]>
Co-authored-by: sleepyyapril <[email protected]>
Co-authored-by: SimpleStation Changelogs <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants