Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prosecutor Access to Evidence Locker #1422

Merged

Conversation

BellwetherLogic
Copy link
Contributor

@BellwetherLogic BellwetherLogic commented Jun 21, 2024

About the PR

Allows Prosecutors to open standard evidence lockers in Security.

Why / Balance

Security is often busy and doesn't have time to handle evidence for Court. This change helps smooth out one of the primary hangups in Court procedure, getting evidence to trial, while also allowing Security to lock up confiscated items so Johnny Tider doesn't steal a Bulldog and magdump the HoS.

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑 Bellwether

  • tweak: Prosecutors can now lock and unlock Security evidence lockers.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jun 21, 2024
@IamVelcroboy
Copy link
Member

I think this is reasonable. I'll wait for any admin to weigh in. But it should be an improvement, imo.

@NullWanderer
Copy link
Contributor

@therealDLondon

Copy link
Member

@therealDLondon therealDLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah should be fine as far as administration is concerned

@NullWanderer NullWanderer merged commit 6d9f52c into DeltaV-Station:master Jul 17, 2024
11 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
# Description

Chatstack.

Can be changed/disabled in settings, and the chat automatically updates
to reflect the change.
Does not interfere with filters, etc.
Also updated ChatMessage class and serverside IChatManager with a new
IgnoreChatStack bool option, default false.

Currently is limited to looking up to 3 messages behind, only because I
feel off adding a textbox to the options.

---

# TODO


- [x] Make sure it works
- [x] Add it to settings
---

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/e020bb35-3bac-4620-80d1-3dbd9dee2d1c)


[ee.webm](https://github.com/user-attachments/assets/bf1c92f0-b52a-47a0-b142-70b1ee5003cc)


</p>
</details>

---

# Changelog

:cl:
- add: Chatstack. Look for it in Options under "General -
Accessibility".

---------

Co-authored-by: sleepyyapril <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants