Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shoukou atmos futureproofing and fish #1410

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Jun 18, 2024

About the PR

  • teg loops have throttle pumps for when thats cherry picked
  • all pumps are powered
  • doubled co2 cooling setup since i do it every single round, grilled it off from salv too
  • 🐟

@deltanedas deltanedas requested a review from IamVelcroboy as a code owner June 18, 2024 08:34
@deltav-mapserver
Copy link

deltav-mapserver bot commented Jun 18, 2024

This PR contains new or changed maps:

Shoukou

image

06/19/24 16:06

@ghost
Copy link

ghost commented Jun 18, 2024

As the current maintainer of Shoukou as a map I approve these changes. Mmm fish.

@IamVelcroboy
Copy link
Member

One criticism is that running cables directly over the pumps can obscure them and make them hare to see/read
image

@deltanedas
Copy link
Member Author

that wasnt me i just powered the cooling pumps :trollface:

@IamVelcroboy
Copy link
Member

The TEG being completely ready to go roundstart is too much. It should require some assembly/complexity. Maybe remove a few radiators and/or connecting pipes. Something, so there is "some assembly required"

@IamVelcroboy
Copy link
Member

that wasnt me i just powered the cooling pumps :trollface:

ahh, fair enough

@deltanedas
Copy link
Member Author

It should require some assembly/complexity

done and replaced 2 useless cans with oxy and plasma

@deltanedas
Copy link
Member Author

@IamVelcroboy approv

@IamVelcroboy IamVelcroboy merged commit 6c2b6ff into DeltaV-Station:master Jul 16, 2024
11 checks passed
@deltanedas deltanedas deleted the shoko-update branch July 16, 2024 20:09
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

Title, doing this to make a single test pass.

---------

Co-authored-by: slarticodefast <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants