Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Subpoenaed" status for SecHud and Criminal Records Computer #1405

Merged
merged 15 commits into from
Jul 1, 2024

Conversation

BellwetherLogic
Copy link
Contributor

About the PR

The Criminal Records Computer can now be used to mark a member of the crew as under subpoena by the Justice Department, meaning that Security should direct or escort them to court immediately. This can be used both to notify Sec that a prisoner is ready for trial ASAP, or to mark witnesses and persons of interest in the broader station population.

Why / Balance

This should simplify the process of serving subpoena paperwork/getting people to court, dramatically cutting down on court delays for witnesses.

Technical details

This is the first time I've actually touched proper code - however, this isn't really anything novel, just adding the appropriate bits in the appropriate places.

Media

2024-06-17.10-51-18.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑 Bellwether

  • add: Sechuds can now be used to mark subpoenaed crew members who are needed in court.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Jun 17, 2024
Copy link
Contributor

github-actions bot commented Jun 17, 2024

RSI Diff Bot; head commit e3ed89f merging into 0b22317
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Interface/Misc/security_icons.rsi

State Old New Status
hud_subpoenaed Added

Edit: diff updated after e3ed89f

Copy link
Contributor

@NullWanderer NullWanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the resource changes have no reason to be in a non deltav namespace, and should be moved

@BellwetherLogic
Copy link
Contributor Author

Okay, after some conflict shenanigans (git is sorcery) I think I have this in a workable position. All files should either be commented or in the DeltaV namespace, and the new meta.json file is (hopefully) appropriately attributed.

@BellwetherLogic
Copy link
Contributor Author

Okay, after a lot of misery and having to learn what BOMs are, I think I've finally got this PR unscrombled. Thank you so much to everyone for being patient with my dumb ass as I learn basic concepts of software development.

deltanedas
deltanedas previously approved these changes Jun 18, 2024
@deltanedas deltanedas enabled auto-merge (squash) June 21, 2024 18:38
auto-merge was automatically disabled June 21, 2024 18:54

Head branch was pushed to by a user without write access

@deltanedas deltanedas requested review from NullWanderer and removed request for NullWanderer June 21, 2024 19:21
@Timemaster99
Copy link
Contributor

SOP rewrite includes subpoenas, so this will mesh nicely

@deltanedas deltanedas merged commit 36695a3 into DeltaV-Station:master Jul 1, 2024
13 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

Moved the whole CPR code to the server. There was no need for it to be
on shared.
Now CPR automatically repeats itself until the person is alive.
CPR can now be performed without getting you mask off. You just need to
lower it down like when trying to eat/drink.
Fixed popups repeating itself x100 times.
Removed cvars and moved everything to CPRTraining component. Why would
anyone place them in cvars anyway?..

---

# Changelog

:cl:
- add: CPR now automatically repeats itself.
- add: CPR no longer requires you to take the mask off. You can now
simply lower it instead.
- fix: Fixed CPR repeating popups x100 times.

Signed-off-by: Remuchi <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants