Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prosecutor and det switch positions ON SHOKO. #1387

Merged
merged 6 commits into from Jun 18, 2024
Merged

Prosecutor and det switch positions ON SHOKO. #1387

merged 6 commits into from Jun 18, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2024

About the PR

Doesn't fix other jarring map issues like the front door of sec on shoko but addresses the astro grass and exposed piping thing, the det office and the prosecutor, and the clerk maints being locked to justice because I forgot to replace that last go-through. Who would've thought.

Why / Balance

I fucked up and then things got changed around with justice again!! :)

Technical details

Fixes #1373

Might get trolled by invalids because I had to do a lot of linking this go-around

Changelog

Doesn't fix other jarring map issues like the sec door on shoko but addresses the astro grass, the det office and the prosecutor, and the clerk maints being locked to justice because I forgor.
@ghost ghost requested a review from IamVelcroboy as a code owner June 15, 2024 04:40
@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • shoukou.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/15/24 04:40

@ghost ghost changed the title Prosecutor and det switch positions Prosecutor and det switch positions ON SHOKO. Jun 15, 2024
@Colin-Tel
Copy link
Contributor

Error says there's no spawnpoint for the Prosecutor job.

Reworks the AI sat to not be shit.
Also adds a prosecutor spawn because I got trolled
@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • shoukou.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/15/24 21:45

@ghost
Copy link
Author

ghost commented Jun 15, 2024

I got trolled by the lack of a prosecutor spawn; also reworked the AI sat / some shielding, so, let's hope I don't get trolled again.

@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • shoukou.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/15/24 21:46

@IamVelcroboy
Copy link
Member

Invalid error is valid

@IamVelcroboy
Copy link
Member

If you're not sure how to fix the invalids there are people in mapping channel that can help you while I'm away. I will still merge when it's fixed though, as it's important to get the Prosecutor's access sorted

@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • shoukou.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/17/24 20:01

@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • shoukou.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/17/24 20:11

@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • shoukou.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/17/24 20:12

@ghost
Copy link
Author

ghost commented Jun 17, 2024

Mapserver, please. I needed to fix atmos and an invalid.

For all intents and purposes I think this PR is done unless the tests find some other issue. But yeah, it's merge-ready.

@IamVelcroboy IamVelcroboy merged commit e96b533 into DeltaV-Station:master Jun 18, 2024
11 checks passed
@ghost ghost deleted the shoukou-again branch June 18, 2024 19:01
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Lots of stuff. Also moved everything I could to the _Shitmed namespace
as I do in Goob. Will make future ports way faster

# Changelog
:cl: Mocho
- add: Added some fun organs and other thingies, check out the Goob PRs
if you want more details.
- fix: Fixed tons of issues with shitmed. Too many for the changelog in
fact.
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shoukou prosecutor office placement
2 participants