Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighthouse justice dept #1322

Merged
merged 10 commits into from
Jun 11, 2024
Merged

lighthouse justice dept #1322

merged 10 commits into from
Jun 11, 2024

Conversation

deltanedas
Copy link
Member

About the PR

  • put justice department in maints right of sec
  • make old lawyer room into a trial evidence room so you can just pull evidence out epic style
  • add screen to evac so you can see the eta
  • sec animal spawner

23:13:11

@deltanedas deltanedas requested a review from IamVelcroboy as a code owner June 7, 2024 22:14
@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • lighthouse.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/07/24 22:14

@Timemaster99
Copy link
Contributor

maints law firm is unmatched

@deltanedas
Copy link
Member Author

yeah im facing execution for murder but have you seen my lawyer? i met him in maints hes gotta be good

@therealDLondon
Copy link
Member

Where prosecutor

@deltanedas
Copy link
Member Author

forgor :trollface:

@therealDLondon
Copy link
Member

HOW

@Timemaster99
Copy link
Contributor

Gavel block mapped somewhere?

@Timemaster99
Copy link
Contributor

Gavel block mapped somewhere?

Same question for Court desk timer

@deltanedas
Copy link
Member Author

no and no :trollface:

@deltanedas
Copy link
Member Author

prosecutor spawns added to the justice room, court stuff in court

@DeltaV-Station DeltaV-Station deleted a comment from deltav-mapserver bot Jun 8, 2024
@DeltaV-Station DeltaV-Station deleted a comment from deltav-mapserver bot Jun 8, 2024
@IamVelcroboy
Copy link
Member

  • Maints Justice is kinda whack, maybe short term, but long term lets find a proper place for them
  • Lawyer needs an office that is separated far enough from Prosecutor that conversations cannot be overheard
  • Chief Justice should spawn in bridge conference room with the rest of the heads
  • Fire/air Alarms?
  • I wonder if it makes more sense to put CJ/Prosecutor where Detective and evidence room are and move detective to the maints office with the lawyer?
    image (Just a suggestion)
  • Keep 2 lawyer slots open
  • If you do keep the evidence room, these should probably be Justice locked?
    image
  • (random) tile missing here
    image
  • Another option might be to move EVA but I don't have a suggestion where 🤷‍♂️

@deltanedas
Copy link
Member Author

long term lets find a proper place for them

ideally it would be right of court but then half the map has to get remade

i think ill do your suggestion of swapping det and cj/prosecutor

@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • lighthouse.yml

Maps are being rendered. This comment will be updated if rendering them is done.
06/08/24 21:20

@deltanedas
Copy link
Member Author

prosector/cj remodeled in here
22:20:03

lawyer/detective cave
22:19:51

@therealDLondon
Copy link
Member

The clerk 💀

@Timemaster99
Copy link
Contributor

prosector/cj remodeled in here 22:20:03

lawyer/detective cave 22:19:51

If you do want to take it out of maints as Velcro suggested, I would suggest turning the maints hallway into a normal hall and just make it two tiles wide by cutting into EVA if needed

@DeltaV-Station DeltaV-Station deleted a comment from deltav-mapserver bot Jun 8, 2024
@IamVelcroboy
Copy link
Member

Funny error says station doesn't exist

@deltanedas

This comment was marked as outdated.

Sign in to view
@DeltaV-Station DeltaV-Station deleted a comment from deltav-mapserver bot Jun 9, 2024
@DeltaV-Station DeltaV-Station deleted a comment from deltav-mapserver bot Jun 9, 2024
@DeltaV-Station DeltaV-Station deleted a comment from deltav-mapserver bot Jun 10, 2024
@IamVelcroboy
Copy link
Member

image

@Timemaster99
Copy link
Contributor

Make sure to add the new Clerk doors, or the Clerk windoor in this case

@deltanedas
Copy link
Member Author

Make sure to add the new Clerk doors, or the Clerk windoor in this case

yes i did that 5 h ago

@DeltaV-Station DeltaV-Station deleted a comment from deltav-mapserver bot Jun 10, 2024
@IamVelcroboy IamVelcroboy merged commit b1ad985 into DeltaV-Station:master Jun 11, 2024
11 checks passed
@deltanedas deltanedas deleted the lighthouse-update branch June 11, 2024 01:40
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
@sleepyyapril @VMSolidus @DEATHB4DEFEAT
CVar CharacterRequirement (DeltaV-Station#1322)
34209e6 
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

This takes in one CVar and one required value and simply checks if the
CVar's value as a string is equal to the required value. I could make it
use a list of them, but I really didn't think it was needed considering
CharacterAndLogic.

I also cleaned up CharacterRequirements.Profile.cs a bit.

---------

Signed-off-by: sleepyyapril <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamVelcroboy IamVelcroboy IamVelcroboy approved these changes

Assignees
No one assigned
Labels
Changes: Map Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deltanedas @Timemaster99 @therealDLondon @IamVelcroboy