Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prescription hud fix #1317

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

Timemaster99
Copy link
Contributor

@Timemaster99 Timemaster99 commented Jun 7, 2024

About the PR

Fixed prescription HUD crafting, since I'm someone who uses it...

Why / Balance

Technical details

Made the construction graph check for VisionCorrection component instead of GlassesNearsight tag

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
🆑 Timemaster99

  • fix: Fixed prescription hud crafting

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jun 7, 2024
Copy link
Contributor

@NullWanderer NullWanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a bad fix. The construction graph should be edited instead to reference something else unique about these sorts of glasses, like the vision correction component

@Timemaster99
Copy link
Contributor Author

No, this is a bad fix. The construction graph should be edited instead to reference something else unique about these sorts of glasses, like the vision correction component

Resolved. I didn't know construction graphs could check for components

@NullWanderer NullWanderer merged commit 81af45d into DeltaV-Station:master Jun 14, 2024
12 checks passed
@Timemaster99 Timemaster99 deleted the presc-hud-fix branch June 25, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants