Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable the mime suit #1286

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

dge21
Copy link
Contributor

@dge21 dge21 commented Jun 2, 2024

About the PR

Re enabled crafting of the mime hardsuit

Why / Balance

The clown hardsuit was re added. I see no reason to enable it and not the mime suit

Technical details

minor yml change, just uncommented some lines

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

none I believe, I just uncommented existing yml
Changelog

🆑

  • add: the mime suit is craftable now!

@github-actions github-actions bot added the Changes: YML Changes any yml files label Jun 2, 2024
@dge21 dge21 changed the title Update hardsuits.yml Re enable the mime suit Jun 2, 2024
@dge21
Copy link
Contributor Author

dge21 commented Jun 2, 2024

can't believe I forgot to name the pr

@Colin-Tel
Copy link
Contributor

You didn't uncomment Resources/Prototypes/Recipes/Construction/Graphs/clothing/mime_hardsuit.yml

@dge21
Copy link
Contributor Author

dge21 commented Jun 2, 2024

oh oops, lemme fix that

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardsuit does not show up in the crafting menu.

image

Signed-off-by: dge21 <[email protected]>
@dge21
Copy link
Contributor Author

dge21 commented Jun 3, 2024

third times the charm, It should work now

@therealDLondon
Copy link
Member

rubber stamp sound
Headmin approv!

@deltanedas
Copy link
Member

most likely fixed now that its uncommented

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@Colin-Tel Colin-Tel merged commit 1a9c5c8 into DeltaV-Station:master Jun 4, 2024
12 checks passed
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

This one took me a few hours to get working. Truly one of the most
important PRs to ever grace this codebase :)

Solves DeltaV-Station#1286 

---

<details><summary><h1>Media</h1></summary>
<p>

# Nuh uh :3

</p>
</details>

---

# Changelog

:cl:
- fix: Remove a filthy, dirty, lie that has ruined the dreams of many
spessmans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants