Allow vulps to wag #1152
Closed
Allow vulps to wag #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: Localization
|
RSI Diff Bot; head commit d6522dc merging into 511685e Resources/Textures/DeltaV/Mobs/Customization/Vulpkanin/tail_markings.rsi
|
This comment was marked as resolved.
This comment was marked as resolved.
|
Will probably make the migration part handled with an EF migration later |
…u-please-get-my-itch-put-paws-on-your-chest-nyea
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Cool. More non-intrusive roleplay mechanics that give people just a little more flexibility? Hell yeah. CD is a treasure trove of uninvasive HRP features that work just fine in MRP, and I am super down to see more PRs mirroring their successes. |
|
Closing this in favor of a port of this from EE or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Vulps can now toggle wagging if their tail supports it. Corgi and dalmatian tails also get a non-wagging variant courtesy of CD.
Why / Balance
People have wanted this for a while, I guess?
Known issues
Technical details
Basically ported from cosmatic-drift-14/cosmatic-drift#214. Uses the lizard tail wagging system. Old "wag" variants are removed and replaced with hidden (in character setup) "animated" variants.
Media
It's exactly the same as the lizard tail wagging.
Breaking changes
Database needs a migration to be run on it that fixes the markings field on profiles, since this PR removes the "wagging" variants we used to have and people have those selected. They need to be replaced with the non-wagging variant in the DB, just look at #rebase.
Changelog
🆑