Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carrypets #1145

Merged
merged 4 commits into from
May 18, 2024
Merged

carrypets #1145

merged 4 commits into from
May 18, 2024

Conversation

Froffy025
Copy link
Contributor

About the PR

adds carriable component to a lot of animals that didn't have it

Why / Balance

grr

Technical details

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: You can now carry most of the station pets.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Apr 27, 2024
@deltanedas
Copy link
Member

why not put on base mob, i want to carry a fish too

also these all need deltav marker comments

@noctyrnal
Copy link
Contributor

why not put on base mob, i want to carry a fish too

also these all need deltav marker comments

something something dreaded fish ops

@DangerRevolution
Copy link
Contributor

this needs Delta-V comments on every single instance of modified upstream code

@Froffy025
Copy link
Contributor Author

added deltaV comments and the dreaded fishops. wasn't sure how to go about adding carriable to basemob and stopping players from holding very heavy mobs

@Froffy025 Froffy025 closed this Apr 28, 2024
@Froffy025 Froffy025 reopened this Apr 28, 2024
@NullWanderer
Copy link
Contributor

@deltanedas Feel free to merge if you have nothing else to add

@deltanedas deltanedas merged commit 0af202e into DeltaV-Station:master May 18, 2024
22 of 23 checks passed
VMSolidus pushed a commit to Simple-Station/Einstein-Engines that referenced this pull request Jul 5, 2024
# Description
Cherry-picks DeltaV-Station/Delta-v#1145

All credit goes to the original author of the PR.

Original description is: "adds carriable component to a lot of animals
that didn't have it"

---

# Why

## Renault my beloved!!!

---


<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/Simple-Station/Einstein-Engines/assets/69920617/12777e9b-7d00-4df2-8703-a7f9e42ea1c6)


</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Froffy025
- add: You can now carry most of the station pets.

---------

Signed-off-by: Froffy025 <[email protected]>
Co-authored-by: Froffy025 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants