Ports Laying down from Cosmatic Drift. #1098

Adrian16199 · 2024-04-15T21:01:42Z

About the PR

Ports laying down.

Why / Balance

Because its the greatest thing known to man. (And woman)

Technical details

Media

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Delta-v.2024-04-15.22-57-35.mp4

Breaking changes

Changelog

🆑

add: You can now lay down and stand up.

Mnemotechnician · 2024-04-16T00:45:36Z

But... why an emote and not a keybind, or button, or anything else that would make more sense for an action that affects gameplay?

Timemaster99 · 2024-04-16T01:40:12Z

I agree with the above comment. This should be an action alongside sleeping, screaming, and harm mode

Adrian16199 · 2024-04-16T09:23:53Z

"Affects gameplay"
Im just gonna ask, how exactly compared to:
Harm mode: Decides whether you are playing TDM (team deatch match), RDM if you are feeling funny or roleplayin game.
Scream: Somethin to indicate you are in distress that isnt neccesarily you spamming emotes or copy pastin scream line while someone is beating you upside the head. Also the sound itself can be heard better than anything else.
Sleeping: Used to cure diseases most of the time and revenants are capable of eating people who are sleeping like a sleeping demon, can only be done in bed.
Closest thing that I can think of affectin gameplay is the fact that you lock yourself in place... and then maybe pretend that you seized up, falled limb, your eyes, dead and lifeless.

Now code wise an action for a mere emote that can simply be keybinded like any other emote would require:
-A sprite for said action
-Coding the action itself
-Coding the fact that it would need to toggle between laying down and THEN standing up.

I cant be bothered for somethin that im simply portin, wantin it ingame as fast as possible because I adore this emote by itself and for somethin that I cant agree with wholeheartedly when it can be done with a simple keybind that already exists for emotes.

DangerRevolution · 2024-04-16T10:02:48Z

"Affects gameplay" Im just gonna ask, how exactly compared to: Harm mode: Decides whether you are playing TDM (team deatch match), RDM if you are feeling funny or roleplayin game. Scream: Somethin to indicate you are in distress that isnt neccesarily you spamming emotes or copy pastin scream line while someone is beating you upside the head. Also the sound itself can be heard better than anything else. Sleeping: Used to cure diseases most of the time and revenants are capable of eating people who are sleeping like a sleeping demon, can only be done in bed.

Not sure why we're filled with hatred towards actions but this:

Closest thing that I can think of affectin gameplay is the fact that you lock yourself in place... and then maybe pretend that you seized up, falled limb, your eyes, dead and lifeless.

is the actual reason why this shouldn't be an action, this is a half-cooked feature that shouldn't be an action and should be relegated to being an HRP emote

Content.Server/_CD/Traits/LayEmoteSystem.cs

Resources/Prototypes/_CD/Voice/lay_emotes.yml

LankLTE · 2024-04-16T19:35:01Z

This system has some issues which I’ve mentioned on discord here.
https://discord.com/channels/968983104247185448/1150555473699934370/1229875767043686410

There’s also a lack of other phrases as I hadn’t fully finished it as of you deciding to port this. As for an action, entirely possible (and pretty easy, actually), but I personally think that filling your sidebars with actions that all just do an emote is a bad idea. Especially when roles like engineers already frequently have 6-8 actions. You may disagree.

Adrian16199 · 2024-05-27T10:45:54Z

Pretty much ready for review.

Resources/Prototypes/_CD/Voice/lay_emotes.yml

Content.Server/_CD/Traits/LayEmoteSystem.cs

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Adrian16199 <[email protected]>

NullWanderer

I feel like I might be missing something, so I'd appreciate it if another maintainer also approved this prior to it being merged. I feel like some horrible bug will reveal itself after this is merged triggered by unique edge cases like the noospheric zap and just result in horrible problems, but I might be overthinking it

deltanedas · 2024-04-15T21:29:11Z

Content.Server/_CD/Traits/LayEmoteComponent.cs

+[RegisterComponent, Access(typeof(LayEmoteSystem))]
+public sealed partial class LayEmoteComponent : Component
+{
+    [DataField("layEmote", customTypeSerializer: typeof(PrototypeIdSerializer<EmotePrototype>))]


[DataField] and use ProtoId

deltanedas · 2024-04-15T21:29:18Z

Content.Server/_CD/Traits/LayEmoteComponent.cs

+    [DataField("standEmote", customTypeSerializer: typeof(PrototypeIdSerializer<EmotePrototype>))]
+    public string StandEmoteId = "StandUp";
+
+    [ViewVariables]


dont need = false

deltanedas · 2024-04-15T21:29:21Z

Content.Server/_CD/Traits/LayEmoteComponent.cs

+    [DataField("layEmote", customTypeSerializer: typeof(PrototypeIdSerializer<EmotePrototype>))]
+    public string LayEmoteId = "LayDown";
+
+    [DataField("standEmote", customTypeSerializer: typeof(PrototypeIdSerializer<EmotePrototype>))]


deltanedas · 2024-06-12T16:35:57Z

Content.Server/_CD/Traits/LayEmoteSystem.cs

+public sealed class LayEmoteSystem : EntitySystem
+{
+    [Dependency] private readonly MovementSpeedModifierSystem _modifier = default!;
+    [Dependency] private readonly StandingStateSystem _standingSystem = default!;


sort alphabetically + rename to not have System as its redundant

deltanedas · 2024-06-12T16:36:52Z

Content.Server/_CD/Traits/LayEmoteSystem.cs

+    // If buckled, make sure someone is standing. Unbuckling while laying down should keep someone laying down and vice versa.
+    private void OnBuckleChange(EntityUid uid, LayEmoteComponent component, ref BuckleChangeEvent args)
+    {
+        if (args.Buckling && component.Laying)


if (!component.Laying) return; then remove from the other if statements

deltanedas · 2024-06-12T16:39:43Z

Content.Server/_CD/Traits/LayEmoteSystem.cs

+        if (component.Laying)
+            args.ModifySpeed(component.CrawlSpeed, component.CrawlSpeed); // Delta V- crawl, baby, crawl!
+
+        if (!component.Laying)


deltanedas · 2024-06-12T16:40:59Z

Content.Server/_CD/Traits/LayEmoteSystem.cs

+    private void OnBuckleChange(EntityUid uid, LayEmoteComponent component, ref BuckleChangeEvent args)
+    {
+        if (args.Buckling && component.Laying)
+            _standingSystem.Stand(args.BuckledEntity);


this will still leave you laying down after unbuckling which is weird

deltanedas · 2024-06-12T16:42:31Z

Content.Server/_CD/Traits/LayEmoteSystem.cs

+    private void OnMobStateChanged(EntityUid uid, LayEmoteComponent component, MobStateChangedEvent args)
+    {
+        // Hoping this should work fine as going crit - dead or dead - crit shouldn't matter, and crit - alive would stand you up anyways.
+        component.Laying = false;


i imagine this could possibly troll your movement speed, add a SetLaying function that 1. checks if arg isnt the same as Laying and 2. does the Stand Down update movespeed etc
then use that everywhere

then here call SetLaying(ent, false);

deltanedas · 2024-06-12T16:43:07Z

Content.Server/_CD/Traits/LayEmoteSystem.cs

+    }
+
+    // On shutdown, make sure people are standing and reset movement speed
+    private void OnShutdown(EntityUid uid, LayEmoteComponent component, ComponentShutdown args)


for all these handlers use Entity<LayEmoteComponent> and ref args

deltanedas · 2024-06-12T16:43:39Z

test how this interacts with different kinds of stunning too

Ports Laying down from Cosmatic Drift.

2980055

github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Apr 15, 2024

DangerRevolution reviewed Apr 16, 2024

View reviewed changes

Content.Server/_CD/Traits/LayEmoteSystem.cs Show resolved Hide resolved

DangerRevolution reviewed Apr 16, 2024

View reviewed changes

Resources/Prototypes/_CD/Voice/lay_emotes.yml Show resolved Hide resolved

Adrian16199 and others added 3 commits April 16, 2024 13:33

Merge branch 'master' into LYING

d86636c

Does the suggestion

aa89af4

Update lay_emotes.yml

7d7eccd

DangerRevolution reviewed Apr 16, 2024

View reviewed changes

Resources/Prototypes/_CD/Voice/lay_emotes.yml Outdated Show resolved Hide resolved

DangerRevolution reviewed Apr 16, 2024

View reviewed changes

Resources/Prototypes/_CD/Voice/lay_emotes.yml Outdated Show resolved Hide resolved

Adrian16199 marked this pull request as draft May 10, 2024 16:55

Adrian16199 and others added 2 commits May 27, 2024 12:31

Merge branch 'master' into LYING

d056613

Updated it with CD and simply added bit more options.

c97fba4

Adrian16199 marked this pull request as ready for review May 27, 2024 10:45

DEATHB4DEFEAT suggested changes May 27, 2024

View reviewed changes

Adrian16199 and others added 4 commits May 27, 2024 21:55

Apply suggestions from code review

80670bc

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Adrian16199 <[email protected]>

Update Content.Server/_CD/Traits/LayEmoteSystem.cs

0a0ad2d

Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Adrian16199 <[email protected]>

Makes it a variable

3cb3204

Merge branch 'master' into LYING

06fb629

NullWanderer approved these changes Jun 12, 2024

View reviewed changes

NullWanderer requested review from DEATHB4DEFEAT and deltanedas June 12, 2024 16:24

github-actions bot added the S: Needs Review label Jun 12, 2024

deltanedas requested changes Jun 12, 2024

View reviewed changes

Adrian16199 closed this Jun 19, 2024

LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025

Fix the CDN Publish Script Being Unrunnable (DeltaV-Station#1098)

00e374c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports Laying down from Cosmatic Drift. #1098

Ports Laying down from Cosmatic Drift. #1098

Adrian16199 commented Apr 15, 2024 •

edited

Loading

Mnemotechnician commented Apr 16, 2024 •

edited

Loading

Timemaster99 commented Apr 16, 2024

Adrian16199 commented Apr 16, 2024

DangerRevolution commented Apr 16, 2024 •

edited

Loading

LankLTE commented Apr 16, 2024

Adrian16199 commented May 27, 2024

NullWanderer left a comment

deltanedas Apr 15, 2024

deltanedas Apr 15, 2024

Adrian16199 Jun 19, 2024

deltanedas Apr 15, 2024

deltanedas Jun 12, 2024

deltanedas Jun 12, 2024

deltanedas Jun 12, 2024

deltanedas Jun 12, 2024

deltanedas Jun 12, 2024

deltanedas Jun 12, 2024

deltanedas commented Jun 12, 2024

Ports Laying down from Cosmatic Drift. #1098

Ports Laying down from Cosmatic Drift. #1098

Conversation

Adrian16199 commented Apr 15, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

Mnemotechnician commented Apr 16, 2024 • edited Loading

Timemaster99 commented Apr 16, 2024

Adrian16199 commented Apr 16, 2024

DangerRevolution commented Apr 16, 2024 • edited Loading

LankLTE commented Apr 16, 2024

Adrian16199 commented May 27, 2024

NullWanderer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deltanedas commented Jun 12, 2024

Adrian16199 commented Apr 15, 2024 •

edited

Loading

Mnemotechnician commented Apr 16, 2024 •

edited

Loading

DangerRevolution commented Apr 16, 2024 •

edited

Loading