Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration + Various items to fix missing prototypes in maps #108

Merged
merged 8 commits into from
Oct 6, 2023

Conversation

FluffiestFloof
Copy link
Contributor

@FluffiestFloof FluffiestFloof commented Oct 5, 2023

About the PR

We're missing book about alerts, shuttle and procedures.
Adds tinfoil hat back in Epi(Sci)Drobe.

Adds back the salvage gaming lore spawner.
Bluespace Powercell is only present in two maps with no research or recipe linked to it so it was replaced by a PowercellHigh.
If we really want it, we can always just make it a research thing.

Why / Balance

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@github-actions github-actions bot added the Changes: YML Changes any yml files label Oct 5, 2023
@FluffiestFloof FluffiestFloof changed the title Migrates stuff for mappers Migrates stuff Oct 5, 2023
@FluffiestFloof FluffiestFloof changed the title Migrates stuff Migration + Various items to fix missing prototypes in maps Oct 5, 2023
@DebugOk
Copy link
Contributor

DebugOk commented Oct 5, 2023

@Colin-Tel or @IamVelcroboy review required for migrations because I'm not a mapping nerd 🤓

@IamVelcroboy
Copy link
Member

looks like

LockerEpistemicsFilled: LockerScienceFilled

was already covered in another PR

@IamVelcroboy
Copy link
Member

Also, mystagogue

@FluffiestFloof
Copy link
Contributor Author

looks like

LockerEpistemicsFilled: LockerScienceFilled

was already covered in another PR

uh which one?

@IamVelcroboy
Copy link
Member

hmm, not sure what's going on on my end...I think I maybe doubled something up...

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, chief.

@Colin-Tel Colin-Tel merged commit b516193 into DeltaV-Station:master Oct 6, 2023
11 checks passed
@FluffiestFloof FluffiestFloof deleted the migration branch October 6, 2023 23:23
DebugOk referenced this pull request in DebugOk/Delta-v Oct 8, 2023
* woo migrating stuff for mappers

* a

* Medical Cyborg and ArachneWeb

* PowerCellBluespace to PowerCellHigh

* Spider legs and salvage lore

* unused

* Actually I might do the medicalborg

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants