Zhangjunyu/inmemory merkletree #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junyu0312
force-pushed
the
zhangjunyu/inmemory-merklytree
branch
from
bb5cf93 to
65515e5
Compare
junyu0312
changed the title
junyu0312
force-pushed
the
zhangjunyu/inmemory-merklytree
branch
from
65515e5 to
331436b
Compare
lanbones
reviewed
Oct 27, 2021
src/merkle-tree-large.ts
Outdated
| private db = new MerkleTreeDb(local_uri, this.db_name); | ||
| private cache; | ||
| private dbName = "delphinus"; | ||
| private db; |
There was a problem hiding this comment.
give type if you can, or add comment with reason
lanbones
reviewed
Oct 27, 2021
src/merkle-tree-large.ts
Outdated
| private db; | ||
| private inMemoryMerkleTree; | ||
|
|
||
| constructor(memData = false) { |
There was a problem hiding this comment.
for name of boolean var, start with is, does ...
lanbones
reviewed
Oct 27, 2021
src/merkle-tree-large.ts
Outdated
| @@ -42,14 +48,20 @@ export class MerkleTree { | |||
| } | |||
|
|
|||
| private async getRawNode(mtIndex: string) { | |||
| return await this.db.queryMerkleTreeNodeFromPath(mtIndex + "I"); | |||
| return await this.db!.queryMerkleTreeNodeFromPath(mtIndex + "I"); | |||
There was a problem hiding this comment.
never use !, otherwise please add comment with reason
Signed-off-by: Zhang Junyu <[email protected]>
junyu0312
force-pushed
the
zhangjunyu/inmemory-merklytree
branch
from
331436b to
7783faa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.