Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iteritems is deprecated #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Iteritems is deprecated #56

wants to merge 1 commit into from

Conversation

ralphbean
Copy link

Cheers! 🥂

@ralphbean
Copy link
Author

I see now that this is causing issues where it is assumed that workflow.iteritems has a predictable order, as specified by the user. I.e., in config.py it is expected that column_names has a particular order that corresponds with the order that the user supplied the workflow column names in their config file. But, dicts don't have predictable order like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ralphbean