-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sitecore 93 23 #26
Open
hollywoodinvegas
wants to merge
26
commits into
DeloitteAU:develop
Choose a base branch
from
hollywoodinvegas:feature/Sitecore_93_23
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/sitecore 93 23 #26
hollywoodinvegas
wants to merge
26
commits into
DeloitteAU:develop
from
hollywoodinvegas:feature/Sitecore_93_23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET Framework upgraded to 4.6.2 Updated Sitecore references to 9.0.180604 Removed unused packages and references from the Test Project
Fixed version number
.NET 4.7.1 Relevant packages Atlas still using a NoReference for Sitecore 9.0.180604 because the updated kernal package includes NVelocity which requires Logging and this currently conflicts with the log4net dll and logging implementation
Note that we no longer have a Sitecore.Kernel.NoReference so we have to include the other dependent libraries and remove log4net .NET upgraded to 4.7.2
.NET Framework 4.8
mt-dd
approved these changes
Jan 31, 2020
Branch will now merge |
Replaced MSTest with XUnit and Shouldly for cleaner tests
Update to deal with Sitecore removing noref packages, the new and improved dotnetcore style package reference rather than package config for nuget |
Update nuspec to requier Sitecore MVC 9.3 and .NET 4.7.2
licenseUrl iconUrl Updated nuget.exe
# Conflicts: # Build/DeloitteDigital.Atlas.nuspec # src/DeloitteDigital.Atlas.Tests/DeloitteDigital.Atlas.Tests.csproj # src/DeloitteDigital.Atlas.Tests/Mapping/ItemPropertyMappingTests.cs # src/DeloitteDigital.Atlas.Tests/Properties/AssemblyInfo.cs # src/DeloitteDigital.Atlas.Tests/app.config # src/DeloitteDigital.Atlas/DeloitteDigital.Atlas.csproj # src/DeloitteDigital.Atlas/Properties/AssemblyInfo.cs # src/DeloitteDigital.Atlas/app.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to 2.3 using Sitecore 9.3 and .NET 4.8