UploadReplacement removes the repack file.

Defacto2 · Sep 22, 2024 · 1505d5f · 1505d5f
1 parent 56c09c1
commit 1505d5f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/handler/htmx/htmx_test.go b/handler/htmx/htmx_test.go
@@ -169,10 +169,10 @@ func TestUploadPreview(t *testing.T) {
 
 func TestUploadReplacement(t *testing.T) {
 	t.Parallel()
-	err := htmx.UploadReplacement(newContext(), nil, "")
+	err := htmx.UploadReplacement(newContext(), nil, "", "")
 	require.NoError(t, err)
 	dir, err := os.Getwd()
 	require.NoError(t, err)
-	err = htmx.UploadReplacement(newContext(), nil, dir)
+	err = htmx.UploadReplacement(newContext(), nil, dir, "")
 	require.NoError(t, err)
 }
diff --git a/handler/htmx/transfer.go b/handler/htmx/transfer.go
@@ -607,7 +607,7 @@ func reloader(c echo.Context, filename string) error {
 // UploadReplacement is the file transfer handler that uploads, validates a new file upload
 // and updates the existing artifact record with the new file information.
 // The logger is optional and if nil then the function will not log any debug information.
-func UploadReplacement(c echo.Context, db *sql.DB, downloadDir string) error {
+func UploadReplacement(c echo.Context, db *sql.DB, downloadDir, extraDir string) error {
 	if db == nil {
 		return c.HTML(http.StatusInternalServerError, "error, the database connection is nil")
 	}
@@ -669,6 +669,8 @@ func UploadReplacement(c echo.Context, db *sql.DB, downloadDir string) error {
 	if err := tx.Commit(); err != nil {
 		return c.HTML(http.StatusInternalServerError, "The database commit failed")
 	}
+	repack := filepath.Join(extraDir, up.unid+".zip")
+	defer os.Remove(repack)
 	if mkc, err := helper.MkContent(abs); err == nil {
 		defer os.RemoveAll(mkc)
 	}

diff --git a/handler/routerlock.go b/handler/routerlock.go
@@ -204,7 +204,7 @@ func editor(g *echo.Group, db *sql.DB, logger *zap.SugaredLogger, dir app.Dirs)
 	upload := g.Group("/upload")
 	// /upload/file
 	upload.POST("/file", func(c echo.Context) error {
-		return htmx.UploadReplacement(c, db, dir.Download)
+		return htmx.UploadReplacement(c, db, dir.Download, dir.Extra)
 	})
 	// /upload/preview
 	upload.POST("/preview", func(c echo.Context) error {