Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop requesting x64 for mac to work on arm #34

Merged
merged 3 commits into from
May 16, 2024
Merged

stop requesting x64 for mac to work on arm #34

merged 3 commits into from
May 16, 2024

Conversation

m-reuter
Copy link
Member

@m-reuter m-reuter commented May 4, 2024

No description provided.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.95%. Comparing base (ae82e8a) to head (961d44b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #34      +/-   ##
========================================
- Coverage   7.26%   6.95%   -0.32%     
========================================
  Files          5       5              
  Lines        633     633              
  Branches      77      77              
========================================
- Hits          46      44       -2     
- Misses       585     586       +1     
- Partials       2       3       +1     
Flag Coverage Δ
unittests 6.95% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-reuter
Copy link
Member Author

I had issues with PyQt6 (for the documentation build with sphinx for unknown reasons), so I went back to PyQt5, but without specifying the exact version 5.15.6 that we pinned before. This older version is not available on all runners. I do not know why that version was explicitly requested.

@m-reuter m-reuter merged commit 8c708fb into main May 16, 2024
28 of 29 checks passed
@m-reuter m-reuter deleted the macbuild branch May 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant