fix(web-ux): remove forbidden css rules

Decathlon · Apr 4, 2022 · f38e641 · f38e641
1 parent 16d451e
commit f38e641
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 37 deletions.
diff --git a/.github/workflows/build-web-ux.yaml b/.github/workflows/build-web-ux.yaml
@@ -62,11 +62,27 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+          ref: ${{ github.ref }}
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v1
         with:
           languages: javascript
           config-file: .github/codeql/codeql-web-ux-config.yml
+      - name: Get project version
+        id: getVersion
+        working-directory: code/web-ux
+        run: |
+          PROJECT_VERSION=$(make -s get-version)
+          echo ::set-output name=projectVersion::${PROJECT_VERSION}
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        with:
+          projectBaseDir: code/web-ux
+          args: >
+            -Dsonar.projectVersion=${{ steps.getVersion.outputs.projectVersion }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v1
       - name: Set up Docker Buildx

diff --git a/code/web-ux/sonar-project.properties b/code/web-ux/sonar-project.properties
@@ -0,0 +1,10 @@
+sonar.organization=decathlon
+sonar.projectName=ARA web-ux
+sonar.projectKey=decathlon_ara_web-ux
+sonar.host.url=https://sonarcloud.io
+
+# Path is relative to the sonar-project.properties file. Defaults to .
+sonar.sources=src
+
+# paths or files to exclude for the analysis
+sonar.exclusions=node_modules
diff --git a/code/web-ux/src/assets/css/global.css b/code/web-ux/src/assets/css/global.css
@@ -3,18 +3,15 @@
 @import '@vtmn/css-utilities/dist/index.css'; /* import Vitamin utilities CSS classes (required) */
 @import 'tailwindcss/screens'; /* import screens CSS classes from Tailwind CSS (optional) */
 @import '@vtmn/css/dist/components.css'; /* import Vitamin components CSS classes (required) */
-@tailwind base;
-@tailwind components;
-@tailwind utilities;
+@import 'tailwindcss/components'; /* import base CSS classes from Tailwind CSS (optional) */
+@import 'tailwindcss/utilities'; /* import base CSS classes from Tailwind CSS (optional) */
 
-@layer components {
-    .vtmn-text-input.nav-search {
-        position: relative;
-        background-color: var(--vtmn-semantic-color_background-secondary);
-        box-shadow: none;
-    }
+.vtmn-text-input.nav-search {
+    position: relative;
+    background-color: var(--vtmn-semantic-color_background-secondary);
+    box-shadow: none;
+}
 
-    .vtmn-text-input.nav-search:hover, .vtmn-text-input.nav-search:focus {
-        box-shadow: none !important;
-    }
+.vtmn-text-input.nav-search:hover, .vtmn-text-input.nav-search:focus {
+    box-shadow: none !important;
 }
diff --git a/code/web-ux/src/callback.html b/code/web-ux/src/callback.html
diff --git a/code/web-ux/src/components/headerNav.vue b/code/web-ux/src/components/headerNav.vue
@@ -25,7 +25,7 @@ export default {
         <span class="vtmx-menu-line" role="presentation"></span>
       </button>
       <RouterLink to="/">
-        <img src="../assets/img/logo.png" width="30" />
+        <img src="../assets/img/logo.png" alt="ara logo" width="30" />
         <h5 class="vtmn-typo_title-5 vtmn-pl-1">ARA</h5>
       </RouterLink>
     </div>