Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the title of the home feed from “Home” to “Dear Blueno” #32

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Sep 20, 2022

Because currently the site doesn’t brand itself in words anywhere.

Screenshot_2022-09-20 17 18 47

@j-f1 j-f1 requested a review from a team as a code owner September 20, 2022 21:19
Copy link
Contributor

@nicholasvadasz nicholasvadasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only worry is on narrower displays this may cause issues. For example, on iPhone XR this causes the "All Time" to get pushed onto two lines when selecting the "Top Of" category.

We are brainstorming different ways to brand/maintain identity though, especially since our redesign saw the disappearance of the Blueno logo from mobile (😢), so this is something we will definitely be experimenting with.

image

@j-f1
Copy link
Contributor Author

j-f1 commented Sep 23, 2022

Made some changes:

Desktop Screenshot_2022-09-23 16 13 34 Screenshot_2022-09-23 16 11 19 Screenshot_2022-09-23 16 11 27
Mobile Screenshot_2022-09-23 16 16 06 Screenshot_2022-09-23 16 15 12 Screenshot_2022-09-23 16 15 31 Screenshot_2022-09-23 16 15 41

@NicholasBottone NicholasBottone added the enhancement New feature or request label Sep 29, 2022
@NicholasBottone
Copy link
Member

While I would like to see the blueno icon (and more of the Dear Blueno branding come back to the home page), I think that this is too large of a header (takes up too much vertical space). I'd support adding the blueno icon to the homepage if it didn't cause any horizontal overflow on mobile. I'm not sure what is the best way to get the full branding involved while keeping the layout looking clean.

@j-f1
Copy link
Contributor Author

j-f1 commented Oct 3, 2022

A simpler approach: tuck the sort options behind a button on mobile. Looks a little bit not-great on the original iPhone width (which IMO is a solid minimum for our userbase in this day and age) but still functions!.

Screenshot_2022-10-03 14 32 27

Screenshot_2022-10-03 14 32 39

Screenshot_2022-10-03 14 32 50

Screenshot_2022-10-03 14 33 00

@j-f1
Copy link
Contributor Author

j-f1 commented Oct 19, 2022

@NicholasBottone I think this is on y’all to review :)

@NicholasBottone
Copy link
Member

Yup sorry for the confusion, I just added this PR as an item to the GitHub Project and it made it say you were assigned to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants