-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the title of the home feed from “Home” to “Dear Blueno” #32
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only worry is on narrower displays this may cause issues. For example, on iPhone XR this causes the "All Time" to get pushed onto two lines when selecting the "Top Of" category.
We are brainstorming different ways to brand/maintain identity though, especially since our redesign saw the disappearance of the Blueno logo from mobile (😢), so this is something we will definitely be experimenting with.
While I would like to see the blueno icon (and more of the Dear Blueno branding come back to the home page), I think that this is too large of a header (takes up too much vertical space). I'd support adding the blueno icon to the homepage if it didn't cause any horizontal overflow on mobile. I'm not sure what is the best way to get the full branding involved while keeping the layout looking clean. |
@NicholasBottone I think this is on y’all to review :) |
Yup sorry for the confusion, I just added this PR as an item to the GitHub Project and it made it say you were assigned to the PR. |
Because currently the site doesn’t brand itself in words anywhere.