Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Fix pre-validation evm tx check #2411

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Sep 5, 2023

Summary

  • PR fixes pre-validation pipeline of EVM transactions to remove the account balance check.
  • Looser check allows EVM tx to be added into the mempool without initial account balance validation check, thus resolving transferdomain tx and evm tx being minted in the same block.
  • Depends on PR to add state trie inside txqueue.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven changed the title Evm/fix pre validate tx EVM: Fix pre-validation evm tx check Sep 5, 2023
@prasannavl prasannavl merged commit a783b1e into master Sep 6, 2023
13 of 15 checks passed
@prasannavl prasannavl deleted the evm/fix-pre-validate-tx branch September 6, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants