Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Fix block gas limit validation #2405

Closed
wants to merge 2 commits into from
Closed

EVM: Fix block gas limit validation #2405

wants to merge 2 commits into from

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Sep 4, 2023 •
edited
Loading

Summary

  • Remove validation check in connect block that checks for the EVM block's total gas used with the MAX_BLOCK_GAS_LIMIT, since currently the block gas used is allowed to exceed the total max gas limit.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven
Copy link
Member Author

sieniven commented Sep 4, 2023

Closing since duplicate PR from #2407

@sieniven sieniven closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl Awaiting requested review from prasannavl

@Bushstar Bushstar Awaiting requested review from Bushstar

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sieniven