Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear eth txs index by sender when clearing mempool #2398

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Clear eth txs index by sender when clearing mempool #2398

merged 2 commits into from
Sep 4, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Aug 31, 2023 •
edited
Loading

Summary

  • Clear sender to evm tx hashes map when clearing mempool.
  • Fixes to feature_evm incorrect mempool limit tx - 65th tx should fail instead of the 64th tx.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven mentioned this pull request Aug 31, 2023
Merged
9 tasks
@prasannavl prasannavl merged commit edf134e into master Sep 4, 2023
12 of 15 checks passed
@prasannavl prasannavl deleted the evm/fix-clear-mempool branch September 4, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shohamc1 shohamc1 shohamc1 approved these changes

@Bushstar Bushstar Bushstar approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sieniven @Bushstar @shohamc1 @prasannavl