Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Add miner tests #2391

Merged
merged 5 commits into from
Aug 30, 2023
Merged

EVM: Add miner tests #2391

merged 5 commits into from
Aug 30, 2023

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Aug 29, 2023 •
edited
Loading

Summary

  • Shift previous miner's mempool limit test into new feature_evm_miner.py test
  • Add test for failed txs in construct block to ensure fee accounting - miner still gets paid for the failed tx

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Aug 29, 2023
@sieniven sieniven changed the title Evm/add miner tests EVM: Add miner tests Aug 30, 2023
@prasannavl prasannavl merged commit 5d47015 into master Aug 30, 2023
12 of 13 checks passed
@prasannavl prasannavl deleted the evm/add-miner-tests branch August 30, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl Awaiting requested review from prasannavl

@Bushstar Bushstar Awaiting requested review from Bushstar

@shohamc1 shohamc1 Awaiting requested review from shohamc1

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieniven @prasannavl