Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: Save contract artifacts to build tree #2371

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

shohamc1
Copy link
Contributor

No description provided.

@shohamc1 shohamc1 requested a review from Bushstar August 30, 2023 04:18
open(
f"{os.path.dirname(__file__)}/../../lib/ain-contracts/dst20/output/bytecode.json",
self.bytecode = json.loads(
open(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's abstract the path finder into a function, instead of if else of the whole codepath.

@prasannavl
Copy link
Member

prasannavl commented Aug 30, 2023

Merging, but we should still improve the above to cut out the noise post PR

@prasannavl prasannavl merged commit bb8f693 into master Aug 30, 2023
13 of 15 checks passed
@prasannavl prasannavl deleted the dst20-build-dir branch August 30, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants