Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Re-enable vmmap blocknumber #2361

Merged
merged 6 commits into from
Aug 22, 2023
Merged

feat: Re-enable vmmap blocknumber #2361

merged 6 commits into from
Aug 22, 2023

Conversation

canonbrother
Copy link
Contributor

Summary

  • re-enable vmmap blocknumber
  • mild fixes on rm prefix 0x and type on evm->dvm
  • hash lookup on auto infer path

RPCs

  • vmmap

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@canonbrother canonbrother mentioned this pull request Aug 21, 2023
Closed
9 tasks
@canonbrother canonbrother marked this pull request as ready for review August 21, 2023 09:18
@canonbrother canonbrother marked this pull request as draft August 21, 2023 09:25
@canonbrother canonbrother self-assigned this Aug 21, 2023
@canonbrother canonbrother marked this pull request as ready for review August 21, 2023 09:30
@canonbrother canonbrother force-pushed the canonbrother/vmmap-blocknumber-reenable branch from 8730ba5 to 838830f Compare August 21, 2023 15:26
@canonbrother canonbrother force-pushed the canonbrother/vmmap-blocknumber-reenable branch from 838830f to 6ac1473 Compare August 22, 2023 01:44
sieniven
sieniven previously approved these changes Aug 22, 2023
View reviewed changes
@Jouzo Jouzo merged commit 9859e68 into master Aug 22, 2023
12 of 15 checks passed
@Jouzo Jouzo deleted the canonbrother/vmmap-blocknumber-reenable branch August 22, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven approved these changes

@Jouzo Jouzo Jouzo approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

Assignees

@canonbrother canonbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canonbrother @Jouzo @sieniven