Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the toolchain madness #2237

Merged
merged 9 commits into from
Jul 27, 2023
Merged

Fix the toolchain madness #2237

merged 9 commits into from
Jul 27, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Jul 27, 2023

Summary

  • The largest headaches in the toolchain is often due to the way depends overrides the toolchains
    • For darwin cross compiles it hijacks the compilers entirely
    • For the others, it reuses the env compilers
  • Rust and cargo ecosystem will attempt to compile it's native libraries on it's own which will result in calling C/XX compilers resulting in nested compilation env that are highly inconsistent since depends simply overrides it.
  • This is further made challenging since some Rust libs will require host builds (eg: build-deps), while some require target builds.
  • This retains the overrides from depends and passes it along cleanly in an attempt to resolve this madness.

Additional

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl mentioned this pull request Jul 27, 2023
9 tasks
@prasannavl prasannavl merged commit 1eeb32c into master Jul 27, 2023
12 of 15 checks passed
@prasannavl prasannavl deleted the pvl/fix-depends-overrides branch July 27, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants