Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ain-evm): remove maxFeePerGas at Legacy and EIP2930 #2236

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix(ain-evm): remove maxFeePerGas at Legacy and EIP2930 #2236

merged 1 commit into from
Jul 27, 2023

Conversation

canonbrother
Copy link
Contributor

Summary

Proper struct transaction maxFeePerGas field on correct tx type

To fix:
https://github.com/DeFiCh/metachain-ts-tests/blob/5c8a6511e416c7f6ea4d4ee98ffc683f6b78badc/tests/test-transaction-version.ts#L43-L44

https://github.com/DeFiCh/metachain-ts-tests/blob/5c8a6511e416c7f6ea4d4ee98ffc683f6b78badc/tests/test-transaction-version.ts#L70-L71

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit b38fc8d into master Jul 27, 2023
11 of 13 checks passed
@prasannavl prasannavl deleted the canonbrother/fix-tx-max-fee-per-gas-field branch July 27, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl approved these changes

@sieniven sieniven Awaiting requested review from sieniven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canonbrother @prasannavl