Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ain-grpc): eth_getBlockByNumber('pending') #2208

Closed
wants to merge 12 commits into from
Closed

feat(ain-grpc): eth_getBlockByNumber('pending') #2208

wants to merge 12 commits into from

Conversation

canonbrother
Copy link
Contributor

@canonbrother canonbrother commented Jul 21, 2023 •
edited
Loading

Summary

  • refactor get block number flow.. "loose"(coupling) block_number_to_u256.. instead of blockNumber(getBlock()), do 2 func separately getBlock() -> block, getBlockNumber(block)
  • Support get pending block feature in eth rpc

Fixes part of #1852 and #2167

RPCs

  • eth_getBlockByNumber('pending')

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@canonbrother canonbrother changed the title feat(ain-grpc): eth_getBlock('pending') feat(ain-grpc): eth_getBlockByNumber('pending') Jul 21, 2023
@canonbrother canonbrother force-pushed the canonbrother/pending-block branch 2 times, most recently from 286824f to 5095225 Compare July 26, 2023 07:11
@canonbrother canonbrother force-pushed the canonbrother/pending-block branch 7 times, most recently from 1349913 to 2b45471 Compare August 14, 2023 04:21
@canonbrother
Copy link
Contributor Author

canonbrother commented Aug 23, 2023 •
edited
Loading

(dangling PR) big hassle was passing gasUsed data to pending block
close.. re-work on other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@canonbrother