Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ERC55 address support #2164

Merged
merged 25 commits into from
Jul 27, 2023
Merged

Refactor ERC55 address support #2164

merged 25 commits into from
Jul 27, 2023

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Jul 7, 2023

No description provided.

prasannavl
prasannavl previously approved these changes Jul 11, 2023
@prasannavl
Copy link
Member

Tests still need fixing. LGTM once sorted.

src/outputtype.cpp Outdated Show resolved Hide resolved
@Bushstar Bushstar changed the title Import Eth address with WIF key Refactor ERC55 address support Jul 19, 2023
prasannavl
prasannavl previously approved these changes Jul 24, 2023
@prasannavl
Copy link
Member

Have to resolve test failures, still before merging. Shaping up great!

prasannavl
prasannavl previously approved these changes Jul 27, 2023
@prasannavl prasannavl merged commit 5f00e62 into master Jul 27, 2023
8 of 13 checks passed
@prasannavl prasannavl deleted the import-eth-addr branch July 27, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants