Revert "Revert "Keep hold of lock""

This reverts commit 29a423c.
DeFiCh · Oct 30, 2024 · c804196 · c804196
1 parent c199613
commit c804196
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/ocean.cpp b/src/ocean.cpp
@@ -71,19 +71,20 @@ bool CatchupOceanIndexer() {
     const auto startTime = std::chrono::steady_clock::now();
 
     CBlockIndex *pindex = nullptr;
-    while (currentHeight < tipHeight) {
+
+    // Lock for the whole catchup duration
+    LOCK(cs_main);
+
+    while (currentHeight <= tipHeight) {
         if (ShutdownRequested()) {
             LogPrintf("Shutdown requested, exiting ocean catchup...\n");
             return false;
         }
 
-        {
-            LOCK(cs_main);
-            pindex = ::ChainActive()[currentHeight];
-            if (!pindex) {
-                LogPrintf("Error: Cannot find block at height %u\n", currentHeight);
-                return false;
-            }
+        pindex = ::ChainActive()[currentHeight];
+        if (!pindex) {
+            LogPrintf("Error: Cannot find block at height %u\n", currentHeight);
+            return false;
         }
 
         CBlock block;