Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include url in all Browse error conditions #5

Closed

Conversation

quodlibetor
Copy link
Contributor

This makes it safer to use fwd-browse as your BROWSER. Even if you haven't started a fwd session at least you'll get the url the program you were using wanted to open.

$ cargo run -q --bin fwd-browse -- http://zombo.com
fwd-browse: Error connecting to socket (is fwd actually connected here?)
Start a fwd session to open: http://zombo.com

@DeCarabas
Copy link
Owner

Why not just print out the URL in browse_url in browse/mod.rs?

@quodlibetor quodlibetor force-pushed the include-url-in-browse-errors branch from 17a8a34 to 7b0d1c1 Compare November 5, 2023 18:20
This makes it safer to use fwd-browse as your BROWSER. Even if you haven't
started a fwd session at least you'll get the url the program you were using
wanted to open.
@quodlibetor quodlibetor force-pushed the include-url-in-browse-errors branch from 7b0d1c1 to bb24fa0 Compare November 5, 2023 18:22
@quodlibetor
Copy link
Contributor Author

Because I didn't actually look at the surrounding code. Updated to use that module.

@quodlibetor quodlibetor deleted the include-url-in-browse-errors branch March 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants