Add Ember Suave & Ember CLI Template Lin #12
Conversation
|
this might be somewhat related to this PR, but have you seen Rob's addon for template linting? |
|
@duggiefresh Tru dat! Added it |
| </article> | ||
| <article class="post" id="post_3"> This is an article for John Doe.</article> | ||
| <article class="post" id="post_1"> This is an article for Jane Doe.</article> | ||
| <article class="post" id="post_2"> This is another article for Jane Doe.</article> |
There was a problem hiding this comment.
do we need to clean up the extra spaces in template?
There was a problem hiding this comment.
Since article is a block element, I put the contents on a new line, but I do think the single line version is very readable. What are your thoughts on this @Ctannerweb – should the content of block elements (div, section, etc.) always be on a new line or should we exercise personal preference?
There was a problem hiding this comment.
If there is only text inside an element then 1 line is perfect. Say you need a span inside a <h1> then it would be multiple lines. @michaeldupuisjr @Daniel-Xu
Is the space before This needed? If there needs to be padding it is normally done with CSS
There was a problem hiding this comment.
@Ctannerweb No, I forgot to remove spaces in some of these files 😁
* Add ember suave and make changes to abide by styleguide * Add `ember-cli-template-lint`
ember-cli-template-lint