Remove some jQuery from executeAllValidators

`element.dataset` and `$element.data` are not the same thing
DavyJonesLocker · Dec 15, 2024 · fa2bbd2 · fa2bbd2
1 parent 8c6fe71
commit fa2bbd2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/dist/client-side-validations.esm.js b/dist/client-side-validations.esm.js
@@ -673,7 +673,8 @@ var isMarkedForDestroy = function isMarkedForDestroy($element) {
   return false;
 };
 var executeAllValidators = function executeAllValidators($element, validators) {
-  if ($element.data('changed') === false || $element.prop('disabled')) {
+  var element = $element[0];
+  if ($element.data('changed') === false || element.disabled) {
     return;
   }
   $element.data('changed', false);

diff --git a/dist/client-side-validations.js b/dist/client-side-validations.js
@@ -677,7 +677,8 @@
     return false;
   };
   var executeAllValidators = function executeAllValidators($element, validators) {
-    if ($element.data('changed') === false || $element.prop('disabled')) {
+    var element = $element[0];
+    if ($element.data('changed') === false || element.disabled) {
       return;
     }
     $element.data('changed', false);

diff --git a/src/index.js b/src/index.js
@@ -184,7 +184,8 @@ const isMarkedForDestroy = ($element) => {
 }
 
 const executeAllValidators = ($element, validators) => {
-  if ($element.data('changed') === false || $element.prop('disabled')) {
+  const element = $element[0]
+  if ($element.data('changed') === false || element.disabled) {
     return
   }
 

diff --git a/vendor/assets/javascripts/rails.validations.js b/vendor/assets/javascripts/rails.validations.js
@@ -677,7 +677,8 @@
     return false;
   };
   var executeAllValidators = function executeAllValidators($element, validators) {
-    if ($element.data('changed') === false || $element.prop('disabled')) {
+    var element = $element[0];
+    if ($element.data('changed') === false || element.disabled) {
       return;
     }
     $element.data('changed', false);