Skip to content

Commit

Permalink
Revert "Relax sqlite3 version constraint"
Browse files Browse the repository at this point in the history 
This reverts commit 20a74dc.
  • Loading branch information
@tagliala
tagliala committed Aug 27, 2024
1 parent 06ec7db commit dfcd0b5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions Appraisals
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ end

appraise 'rails-7.1' do
gem 'rails', '~> 7.1.0'
gem 'sqlite3', '~> 1.7' # FIXME: remove after rails/rails#51592
end

appraise 'rails-7.2' do
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_7.1.gemfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ gem "shotgun"
gem "simplecov"
gem "simplecov-lcov"
gem "sinatra"
gem "sqlite3"
gem "sqlite3", "~> 1.7"
gem "webrick"
gem "rails", "~> 7.1.0"

Expand Down

1 comment on commit dfcd0b5

@tagliala
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues when compiling 2.0 with Rails 7.1 and Ruby 3.0

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/home/runner/work/client_side_validations/client_side_validations/vendor/bundle/ruby/3.0.0/gems/sqlite3-2.0.4/ext/sqlite3
/opt/hostedtoolcache/Ruby/3.0.7/x64/bin/ruby -I
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0 -r
./siteconf20240823-1845-y4224b.rb extconf.rb
Building sqlite3-ruby using packaged sqlite3.
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include
	--without-opt-include=${opt-dir}/include
	--with-opt-lib
	--without-opt-lib=${opt-dir}/lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/opt/hostedtoolcache/Ruby/3.0.7/x64/bin/$(RUBY_BASE_NAME)
	--help
	--download-dependencies
	--with-sqlcipher
	--without-sqlcipher
	--with-sqlcipher-dir
	--without-sqlcipher-dir
	--with-sqlcipher-include
	--without-sqlcipher-include
	--with-sqlcipher-lib
	--without-sqlcipher-lib
	--enable-system-libraries
	--disable-system-libraries
	--with-sqlcipher
	--without-sqlcipher
	--with-sqlcipher-dir
	--without-sqlcipher-dir
	--with-sqlcipher-include
	--without-sqlcipher-include
	--with-sqlcipher-lib
	--without-sqlcipher-lib
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/psych.rb:457:in
`parse_stream': undefined method `parse' for #<Psych::Parser:0x0000556219deb478
@handler=#<Psych::Handlers::DocumentStream:0x0000556219deb590 @stack=[],
@last=nil, @root=nil, @start_line=nil, @start_column=nil, @end_line=nil,
@end_column=nil, @block=#<Proc:0x0000556219deb4c8
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/psych.rb:391>>,
@external_encoding=0> (NoMethodError)
	from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/psych.rb:391:in `parse'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/psych.rb:280:in
`unsafe_load'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/psych.rb:583:in `block
in unsafe_load_file'
	from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/psych.rb:582:in `open'
from /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/psych.rb:582:in
`unsafe_load_file'
	from extconf.rb:161:in `mini_portile_config'
	from extconf.rb:157:in `sqlite3_config'
	from extconf.rb:141:in `minimal_recipe'
	from extconf.rb:51:in `configure_packaged_libraries'
	from extconf.rb:17:in `configure'
	from extconf.rb:284:in `<main>'

extconf failed, exit code 1

Gem files will remain installed in
/home/runner/work/client_side_validations/client_side_validations/vendor/bundle/ruby/3.0.0/gems/sqlite3-2.0.4
for inspection.
Results logged to
/home/runner/work/client_side_validations/client_side_validations/vendor/bundle/ruby/3.0.0/extensions/x86_64-linux/3.0.0/sqlite3-2.0.4/gem_make.out

/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/ext/builder.rb:93:in
`run'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/ext/ext_conf_builder.rb:47:in
`block in build'
  /opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/tempfile.rb:317:in `open'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/ext/ext_conf_builder.rb:26:in
`build'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/ext/builder.rb:159:in
`build_extension'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/ext/builder.rb:193:in
`block in build_extensions'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/ext/builder.rb:190:in
`each'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/ext/builder.rb:190:in
`build_extensions'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/rubygems/installer.rb:837:in
`build_extensions'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/rubygems_gem_installer.rb:71:in
`build_extensions'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/rubygems_gem_installer.rb:28:in
`install'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/source/rubygems.rb:204:in
`install'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/installer/gem_installer.rb:54:in
`install'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/installer/gem_installer.rb:16:in
`install_from_spec'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/installer/parallel_installer.rb:186:in
`do_install'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/installer/parallel_installer.rb:177:in
`block in worker_pool'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/worker.rb:62:in
`apply_func'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/worker.rb:57:in
`block in process_queue'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/worker.rb:54:in
`loop'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/worker.rb:54:in
`process_queue'
/opt/hostedtoolcache/Ruby/3.0.7/x64/lib/ruby/3.0.0/bundler/worker.rb:91:in
`block (2 levels) in create_threads'

An error occurred while installing sqlite3 (2.0.4), and Bundler cannot continue.

In rails_7.1.gemfile:
  sqlite3

Please sign in to comment.